components/autofill/common/autofill_messages.h - Issue 13264002: Requery the autofill server when forms and input fields are dynamically added.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/common/autofill_messages.h

Issue 13264002: Requery the autofill server when forms and input fields are dynamically added. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: minor style fix Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/browser/autofill_manager.cc ('K') | « components/autofill/browser/autofill_metrics_unittest.cc ('k') | components/autofill/common/forms_seen_param.h » ('j') | components/autofill/common/forms_seen_param.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/common/autofill_messages.h

diff --git a/components/autofill/common/autofill_messages.h b/components/autofill/common/autofill_messages.h

index 7a35b17a87ae6c44253ccdf17bb23ce995242456..a5fe134abd2521b2aaad266bc29b9f24a22e724e 100644

--- a/components/autofill/common/autofill_messages.h

+++ b/components/autofill/common/autofill_messages.h

@@ -12,6 +12,7 @@

#include "components/autofill/common/form_data_predictions.h"

#include "components/autofill/common/form_field_data.h"

#include "components/autofill/common/form_field_data_predictions.h"

+#include "components/autofill/common/forms_seen_param.h"

#include "components/autofill/common/password_form_fill_data.h"

#include "components/autofill/common/web_element_descriptor.h"

#include "content/public/common/common_param_traits_macros.h"

@@ -26,6 +27,7 @@

#define IPC_MESSAGE_START AutofillMsgStart

IPC_ENUM_TRAITS(autofill::AutocheckoutStatus)

+IPC_ENUM_TRAITS(autofill::FormsSeenParam)

IPC_STRUCT_TRAITS_BEGIN(autofill::WebElementDescriptor)

IPC_STRUCT_TRAITS_MEMBER(descriptor)

@@ -178,7 +180,7 @@ IPC_MESSAGE_ROUTED0(AutofillMsg_WhitelistedForAutocheckout)

IPC_MESSAGE_ROUTED3(AutofillHostMsg_FormsSeen,

std::vector<FormData> /* forms */,

base::TimeTicks /* timestamp */,

- bool /* has_more_forms */)

+ autofill::FormsSeenParam /* partial or dynamic forms */)

ahutter 2013/04/02 20:11:47 I think this should be the argument name not a des

Raman Kakilate 2013/04/02 20:30:19 comment section is used to specify param name rath

Dane Wallinga 2013/04/02 21:29:30 Done.

// Notification that password forms have been seen that are candidates for

// filling/submitting by the password manager.