Requery the autofill server when forms and input fields are dynamically added.

components/autofill/renderer/autofill_agent.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/renderer/autofill_agent.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/message_loop.h"
 #include "base/string_util.h"
@@ skipping 194 matching lines @@
   if (!frame->parent()) {
     topmost_frame_ = frame;
     form_elements_.clear();
     has_more_forms = form_cache_.ExtractFormsAndFormElements(
         *frame, kRequiredAutofillFields, &forms, &form_elements_);
     is_whitelisted_for_autocheckout_ = false;
   } else {
     form_cache_.ExtractForms(*frame, &forms);
   }
 
+  autofill::FormsSeenParam param = has_more_forms ?
+      autofill::PARTIAL_FORMS_SEEN : autofill::NO_SPECIAL_FORMS_SEEN;
+
   // Always communicate to browser process for topmost frame.
   if (!forms.empty() || !frame->parent()) {
     Send(new AutofillHostMsg_FormsSeen(routing_id(), forms,
                                        forms_seen_timestamp_,
-                                       has_more_forms));
+                                       param));
   }
 }
 
 void AutofillAgent::DidStartProvisionalLoad(WebFrame* frame) {
   if (!frame->parent()) {
     topmost_frame_ = NULL;
     if (click_timer_.IsRunning()) {
       click_timer_.Stop();
       autocheckout_click_in_progress_ = true;
     }
@@ skipping 489 matching lines @@
   std::vector<FormData> forms;
   form_cache_.ExtractFormsAndFormElements(
       *topmost_frame_, 0, &forms, &form_elements_);
 
   // OnGetAllForms should only be called if AutofillAgent reported to
   // AutofillManager that there are more forms
   DCHECK(!forms.empty());
 
   // Report to AutofillManager that all forms are being sent.
   Send(new AutofillHostMsg_FormsSeen(routing_id(), forms,
-                                     forms_seen_timestamp_, false));
+                                     forms_seen_timestamp_,
+                                     NO_SPECIAL_FORMS_SEEN));
 }
 
 void AutofillAgent::OnRequestAutocompleteResult(
     WebFormElement::AutocompleteResult result, const FormData& form_data) {
   if (in_flight_request_form_.isNull())
     return;
 
   if (result == WebFormElement::AutocompleteResultSuccess)
     FillFormIncludingNonFocusableElements(form_data, in_flight_request_form_);
 
@@ skipping 27 matching lines @@
   if (!ClickElement(topmost_frame_->document(),
                     click_element_descriptor)) {
     click_timer_.Stop();
     Send(new AutofillHostMsg_ClickFailed(routing_id(),
                                          MISSING_ADVANCE));
   }
 }
 
 void AutofillAgent::OnWhitelistedForAutocheckout() {
   is_whitelisted_for_autocheckout_ = true;
+  if (forms_have_changed_since_load_)
+    SendDynamicFormsSeen();
 }
 
 void AutofillAgent::ClickFailed() {
   Send(new AutofillHostMsg_ClickFailed(routing_id(),
                                        CANNOT_PROCEED));
 }
 
 void AutofillAgent::ShowSuggestions(const WebInputElement& element,
                                     bool autofill_on_empty_values,
                                     bool requires_caret_at_end,
@@ skipping 137 matching lines @@
   if (web_view)
     web_view->hidePopups();
 
   HideHostAutofillUi();
 }
 
 void AutofillAgent::HideHostAutofillUi() {
   Send(new AutofillHostMsg_HideAutofillUi(routing_id()));
 }
 
+void AutofillAgent::didAssociateFormControls(
+    const WebKit::WebVector<WebKit::WebNode>& nodes) {
+  for (size_t i = 0; i < nodes.size(); ++i) {
+    WebKit::WebNode node = nodes[i];
+    if (node.document().frame() == topmost_frame_) {
+      forms_seen_timestamp_ = base::TimeTicks::Now();
+      forms_have_changed_since_load_ = true;
+      break;
+    }
+  }
+
+  if (forms_have_changed_since_load_ && is_whitelisted_for_autocheckout_)
+    SendDynamicFormsSeen();
+}
+
+void AutofillAgent::SendDynamicFormsSeen() {

[Ilya Sherman, 2013/04/06 00:29:39]

nit: Please name this MaybeSendDynamicFormsSeen(), since it doesn't always send
an IPC message.

[Dane Wallinga, 2013/04/08 22:55:50]

Done.

+  forms_have_changed_since_load_ = false;
+  bool has_more_forms = false;
+  std::vector<FormData> forms;
+  form_elements_.clear();
+  has_more_forms = form_cache_.ExtractFormsAndFormElements(
+      *topmost_frame_, kRequiredAutofillFields, &forms, &form_elements_);

[Ilya Sherman, 2013/04/06 00:29:39]

nit: Write these six lines like so:

  forms_have_changed_since_load_ = false;
  form_elements_.clear();

  std::vector<FormData> forms;
  bool has_more_forms = form_cache_.ExtractFormsAndFormElements(
      *topmost_frame_, kRequiredAutofillFields, &forms, &form_elements_);

[Dane Wallinga, 2013/04/08 22:55:50]

Done.

+  autofill::FormsSeenParam param = has_more_forms ?
+      autofill::PARTIAL_AND_DYNAMIC_FORMS_SEEN : autofill::DYNAMIC_FORMS_SEEN;
+
+  if (!forms.empty()) {
+    Send(new AutofillHostMsg_FormsSeen(routing_id(), forms,
+                                       forms_seen_timestamp_,
+                                       param));
+  }
+}
+
 }  // namespace autofill