Requery the autofill server when forms and input fields are dynamically added.

components/autofill/renderer/autofill_agent.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/renderer/autofill_agent.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/message_loop.h"
 #include "base/string_util.h"
 #include "base/strings/string_split.h"
 #include "base/time.h"
 #include "base/utf_string_conversions.h"
 #include "components/autofill/common/autocheckout_status.h"
 #include "components/autofill/common/autofill_constants.h"
 #include "components/autofill/common/autofill_messages.h"
 #include "components/autofill/common/autofill_switches.h"
 #include "components/autofill/common/form_data.h"
 #include "components/autofill/common/form_data_predictions.h"
 #include "components/autofill/common/form_field_data.h"
+#include "components/autofill/common/forms_seen_param.h"
 #include "components/autofill/common/web_element_descriptor.h"
 #include "components/autofill/renderer/form_autofill_util.h"
 #include "components/autofill/renderer/password_autofill_manager.h"
 #include "content/public/common/password_form.h"
 #include "content/public/common/ssl_status.h"
 #include "content/public/renderer/render_view.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "third_party/WebKit/Source/Platform/chromium/public/WebRect.h"
 #include "third_party/WebKit/Source/Platform/chromium/public/WebURLRequest.h"
@@ skipping 174 matching lines @@
   if (!frame->parent()) {
     topmost_frame_ = frame;
     form_elements_.clear();
     has_more_forms = form_cache_.ExtractFormsAndFormElements(
         *frame, kRequiredAutofillFields, &forms, &form_elements_);
     is_whitelisted_for_autocheckout_ = false;
   } else {
     form_cache_.ExtractForms(*frame, &forms);
   }
 
+  FormsSeenParam param = has_more_forms ?
+      autofill::NO_SPECIAL_FORMS_SEEN : autofill::PARTIAL_FORMS_SEEN;

[ahutter, 2013/04/02 20:11:47]

Is this logic right?

[Dane Wallinga, 2013/04/02 21:29:30]

nope

+
   // Always communicate to browser process for topmost frame.
   if (!forms.empty() || !frame->parent()) {
     Send(new AutofillHostMsg_FormsSeen(routing_id(), forms,
                                        forms_seen_timestamp_,
-                                       has_more_forms));
+                                       param));
   }
 }
 
 void AutofillAgent::DidStartProvisionalLoad(WebFrame* frame) {
   if (!frame->parent()) {
     topmost_frame_ = NULL;
     if (click_timer_.IsRunning()) {
       click_timer_.Stop();
       autocheckout_click_in_progress_ = true;
     }
@@ skipping 489 matching lines @@
   std::vector<FormData> forms;
   form_cache_.ExtractFormsAndFormElements(
       *topmost_frame_, 0, &forms, &form_elements_);
 
   // OnGetAllForms should only be called if AutofillAgent reported to
   // AutofillManager that there are more forms
   DCHECK(!forms.empty());
 
   // Report to AutofillManager that all forms are being sent.
   Send(new AutofillHostMsg_FormsSeen(routing_id(), forms,
-                                     forms_seen_timestamp_, false));
+                                     forms_seen_timestamp_,
+                                     NO_SPECIAL_FORMS_SEEN));
 }
 
 void AutofillAgent::OnRequestAutocompleteResult(
     WebFormElement::AutocompleteResult result, const FormData& form_data) {
   if (in_flight_request_form_.isNull())
     return;
 
   if (result == WebFormElement::AutocompleteResultSuccess)
     FillFormIncludingNonFocusableElements(form_data, in_flight_request_form_);
 
@@ skipping 27 matching lines @@
   if (!ClickElement(topmost_frame_->document(),
                     click_element_descriptor)) {
     click_timer_.Stop();
     Send(new AutofillHostMsg_ClickFailed(routing_id(),
                                          MISSING_ADVANCE));
   }
 }
 
 void AutofillAgent::OnWhitelistedForAutocheckout() {
   is_whitelisted_for_autocheckout_ = true;
+  if (forms_have_changed_since_load_) {
+    forms_have_changed_since_load_ = false;
+    bool has_more_forms = false;
+    std::vector<FormData> forms;
+    form_elements_.clear();
+    has_more_forms = form_cache_.ExtractFormsAndFormElements(
+        *topmost_frame_, kRequiredAutofillFields, &forms, &form_elements_);
+    FormsSeenParam param = has_more_forms ?
+        autofill::DYNAMIC_FORMS_SEEN : autofill::PARTIAL_AND_DYNAMIC_FORMS_SEEN;

[ahutter, 2013/04/02 20:11:47]

Is this backwards?

[Dane Wallinga, 2013/04/02 21:29:30]

most certainly

+    if (!forms.empty()) {
+      Send(new AutofillHostMsg_FormsSeen(routing_id(), forms,
+                                         base::TimeTicks::Now(),

[Raman Kakilate, 2013/04/02 20:30:19]

timestamp should be the one at which this form is seen by the renderer. This
timestamp is used to record metrics.

[Dane Wallinga, 2013/04/02 21:29:30]

Done.

+                                         param));
+    }
+  }
 }
 
 void AutofillAgent::ClickFailed() {
   Send(new AutofillHostMsg_ClickFailed(routing_id(),
                                        CANNOT_PROCEED));
 }
 
 void AutofillAgent::ShowSuggestions(const WebInputElement& element,
                                     bool autofill_on_empty_values,
                                     bool requires_caret_at_end,
@@ skipping 137 matching lines @@
   if (web_view)
     web_view->hidePopups();
 
   HideHostAutofillUi();
 }
 
 void AutofillAgent::HideHostAutofillUi() {
   Send(new AutofillHostMsg_HideAutofillUi(routing_id()));
 }
 
+void AutofillAgent::didAssociateFormControls(
+    const WebKit::WebVector<WebKit::WebNode>& nodes) {
+  for (size_t i = 0; i < nodes.size(); ++i) {
+    WebKit::WebNode node = nodes[i];
+    if (node.document().frame() == topmost_frame_) {
+      forms_have_changed_since_load_ = true;
+      break;
+    }
+  }

[ahutter, 2013/04/02 20:11:47]

new line.

[Dane Wallinga, 2013/04/02 21:29:30]

Done.

+  if (forms_have_changed_since_load_ && is_whitelisted_for_autocheckout_) {
+    forms_have_changed_since_load_ = false;

[ahutter, 2013/04/02 20:11:47]

Extract into a function maybe?

+    bool has_more_forms = false;
+    std::vector<FormData> forms;
+    form_elements_.clear();
+    has_more_forms = form_cache_.ExtractFormsAndFormElements(
+        *topmost_frame_, kRequiredAutofillFields, &forms, &form_elements_);
+    FormsSeenParam param = has_more_forms ?
+        autofill::DYNAMIC_FORMS_SEEN : autofill::PARTIAL_AND_DYNAMIC_FORMS_SEEN;
+    if (!forms.empty()) {
+      Send(new AutofillHostMsg_FormsSeen(routing_id(), forms,
+                                         base::TimeTicks::Now(),

[Raman Kakilate, 2013/04/02 20:30:19]

record the timestamp at the start of the function.

and this code block is similar to 782-796, can we extract a method?

[Dane Wallinga, 2013/04/02 21:29:30]

Done.

+                                         param));
+    }
+  }
+}
+
 }  // namespace autofill