Requery the autofill server when forms and input fields are dynamically added.

components/autofill/renderer/autofill_agent.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/renderer/autofill_agent.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/message_loop.h"
 #include "base/string_util.h"
@@ skipping 198 matching lines @@
         *frame, kRequiredAutofillFields, &forms, &form_elements_);
     is_whitelisted_for_autocheckout_ = false;
   } else {
     form_cache_.ExtractForms(*frame, &forms);
   }
 
   // Always communicate to browser process for topmost frame.
   if (!forms.empty() || !frame->parent()) {
     Send(new AutofillHostMsg_FormsSeen(routing_id(), forms,
                                        forms_seen_timestamp_,
-                                       has_more_forms));
+                                       has_more_forms,

[ahutter, 2013/03/29 19:48:31]

Might be good to collapse these bools into an enum.
PARTIAL_FORM_SEEN.
DYNAMIC_FORM_SEEN,
PARTIAL_AND_DYNAMIC_FORM_SEEN

or something like that and do some bitwise stuff to get these bools out.

[Dane Wallinga, 2013/03/29 21:41:12]

Bitwise stuff? You mean like in the enum define PARTIAL_FORM_SEEN=1,
DYNAMIC_FORM_SEEN=2, and then have has_more_forms = (parameterValue &
PARTIAL_FORM_SEEN) and is_post_document_load = (parameterValue &
DYNAMIC_FORM_SEEN)? Those would live in autofill/common?

[ahutter, 2013/03/29 21:53:08]

Yes.
Yes

Yeah seems like it might be cleaner than having the multiple bool params and
make the code more readable.

+                                       false /* is_post_document_load */));
   }
 }
 
 void AutofillAgent::DidStartProvisionalLoad(WebFrame* frame) {
   if (!frame->parent()) {
     topmost_frame_ = NULL;
     WebKit::WebURL provisional_url =
         frame->provisionalDataSource()->request().url();
     WebKit::WebURL current_url = frame->dataSource()->request().url();
     // If the URL of the topmost frame is changing and the current page is part
@@ skipping 494 matching lines @@
   std::vector<FormData> forms;
   form_cache_.ExtractFormsAndFormElements(
       *topmost_frame_, 0, &forms, &form_elements_);
 
   // OnGetAllForms should only be called if AutofillAgent reported to
   // AutofillManager that there are more forms
   DCHECK(!forms.empty());
 
   // Report to AutofillManager that all forms are being sent.
   Send(new AutofillHostMsg_FormsSeen(routing_id(), forms,
-                                     forms_seen_timestamp_, false));
+                                     forms_seen_timestamp_, false, false));

[ahutter, 2013/03/29 19:48:31]

same comment?

 }
 
 void AutofillAgent::OnRequestAutocompleteResult(
     WebFormElement::AutocompleteResult result, const FormData& form_data) {
   if (in_flight_request_form_.isNull())
     return;
 
   if (result == WebFormElement::AutocompleteResultSuccess)
     FillFormIncludingNonFocusableElements(form_data, in_flight_request_form_);
 
@@ skipping 23 matching lines @@
   if (!ClickElement(topmost_frame_->document(),
                     click_element_descriptor)) {
     click_timer_.Stop();
     Send(new AutofillHostMsg_ClickFailed(routing_id(),
                                          MISSING_ADVANCE));
   }
 }
 
 void AutofillAgent::OnWhitelistedForAutocheckout() {
   is_whitelisted_for_autocheckout_ = true;
+  if (forms_have_changed_since_load_) {
+    forms_have_changed_since_load_ = false;
+    bool has_more_forms = false;
+    std::vector<FormData> forms;
+    form_elements_.clear();
+    has_more_forms = form_cache_.ExtractFormsAndFormElements(
+        *topmost_frame_, kRequiredAutofillFields, &forms, &form_elements_);
+    if (!forms.empty()) {
+      Send(new AutofillHostMsg_FormsSeen(routing_id(), forms,
+                                         base::TimeTicks::Now(),
+                                         has_more_forms,
+                                         true /* is_post_document_load */));
+    }
+  }
 }
 
 void AutofillAgent::ClickFailed() {
   Send(new AutofillHostMsg_ClickFailed(routing_id(),
                                        CANNOT_PROCEED));
 }
 
 void AutofillAgent::ShowSuggestions(const WebInputElement& element,
                                     bool autofill_on_empty_values,
                                     bool requires_caret_at_end,
@@ skipping 137 matching lines @@
   if (web_view)
     web_view->hidePopups();
 
   HideHostAutofillUi();
 }
 
 void AutofillAgent::HideHostAutofillUi() {
   Send(new AutofillHostMsg_HideAutofillUi(routing_id()));
 }
 
+void AutofillAgent::didAssociateFormControls(const WebKit::WebVector<WebKit::WebNode>& nodes) {
+  for (size_t i = 0; i < nodes.size(); ++i) {

[ahutter, 2013/03/29 19:48:31]

Can't use an iterator?

[Dane Wallinga, 2013/03/29 21:41:12]

Well at least in WebKit, it's preferred that indexing is used when iterating
over vectors. Can't find any reference to it at all in the Chrome style guide.

+    WebKit::WebNode node = nodes[i];
+    if (node.document().frame() == topmost_frame_) {
+      forms_have_changed_since_load_ = true;

[ahutter, 2013/03/29 19:48:31]

I think you only want to do this once if any of hte nodes was affect:

for (...) {
  if (node.document().frame() == top_most_frame_) {
    forms_have_changed_since_load_ = true;
    break;
  }
}

if (forms_have_changed_since_load_ && is_whitelisted_for_autocheckoutt) {
  // do the other stuff
}

But  I could be completely wrong.

[Dane Wallinga, 2013/03/29 21:41:12]

I have a return further down.

[ahutter, 2013/03/29 21:53:08]

I get that this works but it's more fragile to future changes then it needs to
be in its current form.

[Dane Wallinga, 2013/04/02 19:50:53]

Done.

+      if (is_whitelisted_for_autocheckout_) {
+        forms_have_changed_since_load_ = false;
+        bool has_more_forms = false;
+        std::vector<FormData> forms;
+        form_elements_.clear();
+        has_more_forms = form_cache_.ExtractFormsAndFormElements(
+            *topmost_frame_, kRequiredAutofillFields, &forms, &form_elements_);
+        if (!forms.empty()) {
+          Send(new AutofillHostMsg_FormsSeen(routing_id(), forms,
+                                             base::TimeTicks::Now(),
+                                             has_more_forms,
+                                             true /* is_post_document_load */));
+        }
+      }
+      return;

[ahutter, 2013/03/29 19:48:31]

Oh.  There's a return.  That's why this does the right thing. Doh.

[Dane Wallinga, 2013/03/29 21:41:12]

Yeah, this one.

+    }
+  }
+}
+
 }  // namespace autofill