Requery the autofill server when forms and input fields are dynamically added.

components/autofill/browser/autofill_metrics_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/string16.h"
 #include "base/time.h"
 #include "base/utf_string_conversions.h"
@@ skipping 769 matching lines @@
   form.fields.push_back(field);
   autofill_test::CreateTestFormField("Email", "email", "", "text", &field);
   form.fields.push_back(field);
 
   std::vector<FormData> forms(1, form);
 
   // Ensure no metrics are logged when loading a non-fillable form.
   {
     EXPECT_CALL(*autofill_manager_->metric_logger(),
                 LogDeveloperEngagementMetric(_)).Times(0);
-    autofill_manager_->OnFormsSeen(forms, TimeTicks(), false);
+    autofill_manager_->OnFormsSeen(forms, TimeTicks(), false, false);

[ahutter, 2013/03/29 19:48:31]

Might want to add a TODO somewhere to collect metrics for partial and dynamic
forms.

[Dane Wallinga, 2013/03/29 21:41:12]

Is it just that the current code path doesn't distinguish?

[ahutter, 2013/03/29 21:53:08]

Just no UMA metrics for these new kinds of forms were filling.  You should
probably ask Ilya if it's worth tracking when he reviews.

[Dane Wallinga, 2013/04/02 19:50:53]

will do

     autofill_manager_->Reset();
     Mock::VerifyAndClearExpectations(autofill_manager_->metric_logger());
   }
 
   // Add another field to the form, so that it becomes fillable.
   autofill_test::CreateTestFormField("Phone", "phone", "", "text", &field);
   forms.back().fields.push_back(field);
 
   // Expect only the "form parsed" metric to be logged; no metrics about
   // author-specified field type hints.
   {
     EXPECT_CALL(
         *autofill_manager_->metric_logger(),
         LogDeveloperEngagementMetric(
             AutofillMetrics::FILLABLE_FORM_PARSED)).Times(1);
     EXPECT_CALL(
         *autofill_manager_->metric_logger(),
         LogDeveloperEngagementMetric(
             AutofillMetrics::FILLABLE_FORM_CONTAINS_TYPE_HINTS)).Times(0);
-    autofill_manager_->OnFormsSeen(forms, TimeTicks(), false);
+    autofill_manager_->OnFormsSeen(forms, TimeTicks(), false, false);
     autofill_manager_->Reset();
     Mock::VerifyAndClearExpectations(autofill_manager_->metric_logger());
   }
 
   // Add some fields with an author-specified field type to the form.
   // We need to add at least three fields, because a form must have at least
   // three fillable fields to be considered to be autofillable; and if at least
   // one field specifies an explicit type hint, we don't apply any of our usual
   // local heuristics to detect field types in the rest of the form.
   autofill_test::CreateTestFormField("", "", "", "text", &field);
@@ skipping 10 matching lines @@
   // hints metric to be logged.
   {
     EXPECT_CALL(
         *autofill_manager_->metric_logger(),
         LogDeveloperEngagementMetric(
             AutofillMetrics::FILLABLE_FORM_PARSED)).Times(1);
     EXPECT_CALL(
         *autofill_manager_->metric_logger(),
         LogDeveloperEngagementMetric(
             AutofillMetrics::FILLABLE_FORM_CONTAINS_TYPE_HINTS)).Times(1);
-    autofill_manager_->OnFormsSeen(forms, TimeTicks(), false);
+    autofill_manager_->OnFormsSeen(forms, TimeTicks(), false, false);
     autofill_manager_->Reset();
     Mock::VerifyAndClearExpectations(autofill_manager_->metric_logger());
   }
 }
 
 // Test that we don't log quality metrics for non-autofillable forms.
 TEST_F(AutofillMetricsTest, NoQualityMetricsForNonAutofillableForms) {
   // Forms must include at least three fields to be auto-fillable.
   FormData form;
   form.name = ASCIIToUTF16("TestForm");
@@ skipping 258 matching lines @@
 }
 
 // Test that we log whether Autofill is enabled when filling a form.
 TEST_F(AutofillMetricsTest, AutofillIsEnabledAtPageLoad) {
   // Establish our expectations.
   ::testing::InSequence dummy;
   EXPECT_CALL(*autofill_manager_->metric_logger(),
               LogIsAutofillEnabledAtPageLoad(true)).Times(1);
 
   autofill_manager_->set_autofill_enabled(true);
-  autofill_manager_->OnFormsSeen(std::vector<FormData>(), TimeTicks(), false);
+  autofill_manager_->OnFormsSeen(std::vector<FormData>(), TimeTicks(), false, false);
 
   // Reset the autofill manager state.
   autofill_manager_->Reset();
 
   // Establish our expectations.
   EXPECT_CALL(*autofill_manager_->metric_logger(),
               LogIsAutofillEnabledAtPageLoad(false)).Times(1);
 
   autofill_manager_->set_autofill_enabled(false);
-  autofill_manager_->OnFormsSeen(std::vector<FormData>(), TimeTicks(), false);
+  autofill_manager_->OnFormsSeen(std::vector<FormData>(), TimeTicks(), false, false);
 }
 
 // Test that credit card infobar metrics are logged correctly.
 TEST_F(AutofillMetricsTest, CreditCardInfoBar) {
   testing::NiceMock<MockAutofillMetrics> metric_logger;
   ::testing::InSequence dummy;
 
   // Accept the infobar.
   {
     scoped_ptr<ConfirmInfoBarDelegate> infobar(CreateDelegate(&metric_logger));
@@ skipping 92 matching lines @@
   form.fields.push_back(field);
   autofill_test::CreateTestFormField("Email", "email", "", "text", &field);
   form.fields.push_back(field);
 
   std::vector<FormData> forms(1, form);
 
   // Expect no notifications when the form is first seen.
   {
     EXPECT_CALL(*autofill_manager_->metric_logger(),
                 LogUserHappinessMetric(AutofillMetrics::FORMS_LOADED)).Times(0);
-    autofill_manager_->OnFormsSeen(forms, TimeTicks(), false);
+    autofill_manager_->OnFormsSeen(forms, TimeTicks(), false, false);
   }
 
 
   // Expect no notifications when the form is submitted.
   {
     EXPECT_CALL(
         *autofill_manager_->metric_logger(),
         LogUserHappinessMetric(
             AutofillMetrics::SUBMITTED_FILLABLE_FORM_AUTOFILLED_ALL)).Times(0);
     EXPECT_CALL(
@@ skipping 15 matching lines @@
   autofill_test::CreateTestFormField("Phone", "phone", "", "text", &field);
   form.fields.push_back(field);
   autofill_test::CreateTestFormField("Unknown", "unknown", "", "text", &field);
   form.fields.push_back(field);
   forms.front() = form;
 
   // Expect a notification when the form is first seen.
   {
     EXPECT_CALL(*autofill_manager_->metric_logger(),
                 LogUserHappinessMetric(AutofillMetrics::FORMS_LOADED));
-    autofill_manager_->OnFormsSeen(forms, TimeTicks(), false);
+    autofill_manager_->OnFormsSeen(forms, TimeTicks(), false, false);
   }
 
   // Expect a notification when the form is submitted.
   {
     EXPECT_CALL(*autofill_manager_->metric_logger(),
                 LogUserHappinessMetric(
                     AutofillMetrics::SUBMITTED_NON_FILLABLE_FORM));
     autofill_manager_->FormSubmitted(form, TimeTicks::Now());
   }
 
@@ skipping 79 matching lines @@
   form.fields.push_back(field);
   autofill_test::CreateTestFormField("Phone", "phone", "", "text", &field);
   form.fields.push_back(field);
 
   std::vector<FormData> forms(1, form);
 
   // Expect a notification when the form is first seen.
   {
     EXPECT_CALL(*autofill_manager_->metric_logger(),
                 LogUserHappinessMetric(AutofillMetrics::FORMS_LOADED));
-    autofill_manager_->OnFormsSeen(forms, TimeTicks(), false);
+    autofill_manager_->OnFormsSeen(forms, TimeTicks(), false, false);
   }
 
   // Simulate typing.
   {
     EXPECT_CALL(*autofill_manager_->metric_logger(),
                 LogUserHappinessMetric(AutofillMetrics::USER_DID_TYPE));
     autofill_manager_->OnTextFieldDidChange(form, form.fields.front(),
                                             TimeTicks());
   }
 
@@ skipping 99 matching lines @@
     EXPECT_CALL(*autofill_manager_->metric_logger(),
                 LogFormFillDurationFromLoadWithAutofill(_)).Times(0);
     EXPECT_CALL(*autofill_manager_->metric_logger(),
                 LogFormFillDurationFromLoadWithoutAutofill(
                     TimeDelta::FromInternalValue(16)));
     EXPECT_CALL(*autofill_manager_->metric_logger(),
                 LogFormFillDurationFromInteractionWithAutofill(_)).Times(0);
     EXPECT_CALL(*autofill_manager_->metric_logger(),
                 LogFormFillDurationFromInteractionWithoutAutofill(_)).Times(0);
     autofill_manager_->OnFormsSeen(
-        forms, TimeTicks::FromInternalValue(1), false);
+        forms, TimeTicks::FromInternalValue(1), false, false);
     autofill_manager_->FormSubmitted(form, TimeTicks::FromInternalValue(17));
     autofill_manager_->Reset();
     Mock::VerifyAndClearExpectations(autofill_manager_->metric_logger());
   }
 
   // Expect metric to be logged if the user manually edited a form field.
   {
     EXPECT_CALL(*autofill_manager_->metric_logger(),
                 LogFormFillDurationFromLoadWithAutofill(_)).Times(0);
     EXPECT_CALL(*autofill_manager_->metric_logger(),
                 LogFormFillDurationFromLoadWithoutAutofill(
                     TimeDelta::FromInternalValue(16)));
     EXPECT_CALL(*autofill_manager_->metric_logger(),
                 LogFormFillDurationFromInteractionWithAutofill(_)).Times(0);
     EXPECT_CALL(*autofill_manager_->metric_logger(),
                 LogFormFillDurationFromInteractionWithoutAutofill(
                     TimeDelta::FromInternalValue(14)));
     autofill_manager_->OnFormsSeen(
-        forms, TimeTicks::FromInternalValue(1), false);
+        forms, TimeTicks::FromInternalValue(1), false, false);
     autofill_manager_->OnTextFieldDidChange(form, form.fields.front(),
                                             TimeTicks::FromInternalValue(3));
     autofill_manager_->FormSubmitted(form, TimeTicks::FromInternalValue(17));
     autofill_manager_->Reset();
     Mock::VerifyAndClearExpectations(autofill_manager_->metric_logger());
   }
 
   // Expect metric to be logged if the user autofilled the form.
   form.fields[0].is_autofilled = true;
   {
     EXPECT_CALL(*autofill_manager_->metric_logger(),
                 LogFormFillDurationFromLoadWithAutofill(
                     TimeDelta::FromInternalValue(16)));
     EXPECT_CALL(*autofill_manager_->metric_logger(),
                 LogFormFillDurationFromLoadWithoutAutofill(_)).Times(0);
     EXPECT_CALL(*autofill_manager_->metric_logger(),
                 LogFormFillDurationFromInteractionWithAutofill(
                     TimeDelta::FromInternalValue(12)));
     EXPECT_CALL(*autofill_manager_->metric_logger(),
                 LogFormFillDurationFromInteractionWithoutAutofill(_)).Times(0);
     autofill_manager_->OnFormsSeen(
-        forms, TimeTicks::FromInternalValue(1), false);
+        forms, TimeTicks::FromInternalValue(1), false, false);
     autofill_manager_->OnDidFillAutofillFormData(
         TimeTicks::FromInternalValue(5));
     autofill_manager_->FormSubmitted(form, TimeTicks::FromInternalValue(17));
     autofill_manager_->Reset();
     Mock::VerifyAndClearExpectations(autofill_manager_->metric_logger());
   }
 
   // Expect metric to be logged if the user both manually filled some fields
   // and autofilled others.  Messages can arrive out of order, so make sure they
   // take precedence appropriately.
   {
     EXPECT_CALL(*autofill_manager_->metric_logger(),
                 LogFormFillDurationFromLoadWithAutofill(
                     TimeDelta::FromInternalValue(16)));
     EXPECT_CALL(*autofill_manager_->metric_logger(),
                 LogFormFillDurationFromLoadWithoutAutofill(_)).Times(0);
     EXPECT_CALL(*autofill_manager_->metric_logger(),
                 LogFormFillDurationFromInteractionWithAutofill(
                     TimeDelta::FromInternalValue(14)));
     EXPECT_CALL(*autofill_manager_->metric_logger(),
                 LogFormFillDurationFromInteractionWithoutAutofill(_)).Times(0);
     autofill_manager_->OnFormsSeen(
-        forms, TimeTicks::FromInternalValue(1), false);
+        forms, TimeTicks::FromInternalValue(1), false, false);
     autofill_manager_->OnDidFillAutofillFormData(
         TimeTicks::FromInternalValue(5));
     autofill_manager_->OnTextFieldDidChange(form, form.fields.front(),
                                             TimeTicks::FromInternalValue(3));
     autofill_manager_->FormSubmitted(form, TimeTicks::FromInternalValue(17));
     autofill_manager_->Reset();
     Mock::VerifyAndClearExpectations(autofill_manager_->metric_logger());
   }
 }