Requery the autofill server when forms and input fields are dynamically added.

chrome/renderer/autofill/autofill_renderer_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/utf_string_conversions.h"
 #include "chrome/test/base/chrome_render_view_test.h"
 #include "components/autofill/common/autofill_messages.h"
 #include "components/autofill/common/form_data.h"
 #include "components/autofill/common/form_field_data.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/WebKit/Source/Platform/chromium/public/WebString.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebDocument.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebInputElement.h"
 
 using WebKit::WebDocument;
 using WebKit::WebFrame;
 using WebKit::WebInputElement;
 using WebKit::WebString;
 
 namespace autofill {
 
 TEST_F(ChromeRenderViewTest, SendForms) {
   // Don't want any delay for form state sync changes. This will still post a
   // message so updates will get coalesced, but as soon as we spin the message
   // loop, it will generate an update.
   SendContentStateImmediately();
 
-  LoadHTML("<form method=\"POST\">"
+  LoadHTML("<form method=\"POST\" id=\"testform\">"
            "  <input type=\"text\" id=\"firstname\"/>"
            "  <input type=\"text\" id=\"middlename\"/>"
            "  <input type=\"text\" id=\"lastname\" autoComplete=\"off\"/>"
            "  <input type=\"hidden\" id=\"email\"/>"
            "  <select id=\"state\"/>"
            "    <option>?</option>"
            "    <option>California</option>"
            "    <option>Texas</option>"
            "  </select>"
            "</form>");
@@ skipping 77 matching lines @@
   expected.value = string16();
   expected.form_control_type = "text";
   expected.max_length = WebInputElement::defaultMaxLength();
   EXPECT_FORM_FIELD_DATA_EQUALS(expected, form2.fields[1]);
 
   expected.name = ASCIIToUTF16("state");
   expected.value = ASCIIToUTF16("?");
   expected.form_control_type = "select-one";
   expected.max_length = 0;
   EXPECT_FORM_FIELD_DATA_EQUALS(expected, form2.fields[2]);
+
+  autofill_agent_->OnWhitelistedForAutocheckout();

[ahutter, 2013/03/29 19:48:31]

Might want to make this a new TEST_F

[Dane Wallinga, 2013/03/29 21:41:12]

Done.

+  render_thread_->sink().ClearMessages();
+  ExecuteJavaScript("newInput=document.createElement(\"input\");"

[ahutter, 2013/03/29 19:48:31]

nit but should this be "var newInput="

[Dane Wallinga, 2013/03/29 21:41:12]

Done.

+                    "newInput.setAttribute(\"type\",\"text\");"
+                    "newInput.setAttribute(\"id\", \"telephone\");"
+                    "document.getElementById(\"testform\").appendChild(newInput);");
+  msg_loop_.RunUntilIdle();
+  // Verify that FormsSeen is resent with the new field.
+  const IPC::Message* message3 = render_thread_->sink().GetFirstMessageMatching(
+      AutofillHostMsg_FormsSeen::ID);
+  ASSERT_NE(static_cast<IPC::Message*>(NULL), message3);
+  AutofillHostMsg_FormsSeen::Read(message3, &params);
+  const std::vector<FormData>& new_forms = params.a;
+  ASSERT_EQ(1UL, new_forms.size());
+  ASSERT_EQ(5UL, new_forms[0].fields.size());
+
+  expected.name = ASCIIToUTF16("telephone");
+  expected.value = string16();
+  expected.form_control_type = "text";
+  expected.max_length = WebInputElement::defaultMaxLength();
+  EXPECT_FORM_FIELD_DATA_EQUALS(expected, forms[0].fields[4]);
 }
 
 TEST_F(ChromeRenderViewTest, FillFormElement) {
   // Don't want any delay for form state sync changes. This will still post a
   // message so updates will get coalesced, but as soon as we spin the message
   // loop, it will generate an update.
   SendContentStateImmediately();
 
   LoadHTML("<form method=\"POST\">"
            "  <input type=\"text\" id=\"firstname\"/>"
@@ skipping 81 matching lines @@
   autofill_agent_->InputElementClicked(middlename, true, true);
   const IPC::Message* message2 = render_thread_->sink().GetFirstMessageMatching(
       AutofillHostMsg_QueryFormFieldAutofill::ID);
   ASSERT_NE(static_cast<IPC::Message*>(NULL), message2);
   // TODO(isherman): It would be nice to verify here that the message includes
   // the correct data.  I'm not sure how to extract that information from an
   // IPC::Message though.
 }
 
 }  // namespace autofill