Make write_library_dependencies.py find all transitive dependencies

Make write_library_dependencies.py find all transitive dependencies

For the component build, it is impractical/impossible to explicitly
list all library dependencies. This list is required (in dependency
order) for several of the apk-building steps.

For now, we will generate this list as follows:
Use readelf to find all transitive dependencies
Topologically sort those dependencies

Once we can expose this information from gyp
(http://crbug.com/2255588), it is straightforward to update this action
to use the gyp-exposed list of libraries.

BUG=158821
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192103

[Yaron, 2013-04-02 01:30:35]

https://codereview.chromium.org/13261024/diff/1008/build/android/setup.gyp
File build/android/setup.gyp (right):

https://codereview.chromium.org/13261024/diff/1008/build/android/setup.gyp#ne...
build/android/setup.gyp:7: # These libraries from the Android ndk are required
to be packaged with
This is only true for the component build and so you could condition the
target's existence on component build, but there doesn't appear to be much harm
as it is. Actually, this might break an "all" build for webview without
addressing comment below. Even still, it may be undesirable for them

https://codereview.chromium.org/13261024/diff/1008/build/android/setup.gyp#ne...
build/android/setup.gyp:17:
'<(DEPTH)/third_party/android_tools/ndk/sources/cxx-stl/stlport/libs/<(android_app_abi)/libstlport_shared.so',
Can you not use <(android_ndk_root) ?

https://codereview.chromium.org/13261024/diff/1008/build/android/setup.gyp#ne...
build/android/setup.gyp:17:
'<(DEPTH)/third_party/android_tools/ndk/sources/cxx-stl/stlport/libs/<(android_app_abi)/libstlport_shared.so',
Can you add a comment to build/common.gypi where the include paths are set to
mention that this needs to be updated accordingly.

https://codereview.chromium.org/13261024/diff/1008/build/android/write_ordere...
File build/android/write_ordered_libraries.py (right):

https://codereview.chromium.org/13261024/diff/1008/build/android/write_ordere...
build/android/write_ordered_libraries.py:1: #!/usr/bin/env python
Move to build/android/gyp

https://codereview.chromium.org/13261024/diff/1008/build/android/write_ordere...
build/android/write_ordered_libraries.py:18: # http://crbug.com/2255588
That link doesn't work for me. Wrong #?

And ya, seems pretty inefficient as is and belongs in gyp

https://codereview.chromium.org/13261024/diff/1008/build/android/write_ordere...
build/android/write_ordered_libraries.py:28: options = None
globals should be prefixed with "_"

https://codereview.chromium.org/13261024/diff/1008/build/android/write_ordere...
build/android/write_ordered_libraries.py:46: def GetDependencies(library_name):
GetNonSystemLibraryDependencies

https://codereview.chromium.org/13261024/diff/1008/build/android/write_ordere...
build/android/write_ordered_libraries.py:48: library_re = re.compile(
compile this once at module level

https://codereview.chromium.org/13261024/diff/1008/build/android/write_ordere...
build/android/write_ordered_libraries.py:51: return set([lib for lib in matches
if not IsSystemLibrary(lib)])
If you're always excluding system libraries, how are they pushed/bundled into
the apk?

https://codereview.chromium.org/13261024/diff/1008/build/android/write_ordere...
build/android/write_ordered_libraries.py:72: for (library, dependencies) in
unsorted_deps.items():
nit: no parens

https://codereview.chromium.org/13261024/diff/1008/build/android/write_ordere...
build/android/write_ordered_libraries.py:85: parser.add_option('--readelf')
Add help

https://codereview.chromium.org/13261024/diff/1008/build/java_apk.gypi
File build/java_apk.gypi (right):

https://codereview.chromium.org/13261024/diff/1008/build/java_apk.gypi#newcod...
build/java_apk.gypi:154: # TODO(cjhopman): Do we need to use readelf from the
android toolchain?
Let's. android_toolchain should give you what you want.

[cjhopman, 2013-04-02 20:47:31]

https://codereview.chromium.org/13261024/diff/1008/build/android/setup.gyp
File build/android/setup.gyp (right):

https://codereview.chromium.org/13261024/diff/1008/build/android/setup.gyp#ne...
build/android/setup.gyp:7: # These libraries from the Android ndk are required
to be packaged with
On 2013/04/02 01:30:35, Yaron wrote:
> This is only true for the component build and so you could condition the
> target's existence on component build, but there doesn't appear to be much
harm
> as it is. Actually, this might break an "all" build for webview without
> addressing comment below. Even still, it may be undesirable for them

Done.

https://codereview.chromium.org/13261024/diff/1008/build/android/setup.gyp#ne...
build/android/setup.gyp:17:
'<(DEPTH)/third_party/android_tools/ndk/sources/cxx-stl/stlport/libs/<(android_app_abi)/libstlport_shared.so',
On 2013/04/02 01:30:35, Yaron wrote:
> Can you not use <(android_ndk_root) ?

Done.

https://codereview.chromium.org/13261024/diff/1008/build/android/setup.gyp#ne...
build/android/setup.gyp:17:
'<(DEPTH)/third_party/android_tools/ndk/sources/cxx-stl/stlport/libs/<(android_app_abi)/libstlport_shared.so',
On 2013/04/02 01:30:35, Yaron wrote:
> Can you add a comment to build/common.gypi where the include paths are set to
> mention that this needs to be updated accordingly.

I've refactored common.gypi so that any changes to the stlport/libstdc++
directories should only be needed in one place.

https://codereview.chromium.org/13261024/diff/1008/build/android/write_ordere...
File build/android/write_ordered_libraries.py (right):

https://codereview.chromium.org/13261024/diff/1008/build/android/write_ordere...
build/android/write_ordered_libraries.py:1: #!/usr/bin/env python
On 2013/04/02 01:30:35, Yaron wrote:
> Move to build/android/gyp

Done.

https://codereview.chromium.org/13261024/diff/1008/build/android/write_ordere...
build/android/write_ordered_libraries.py:18: # http://crbug.com/2255588
On 2013/04/02 01:30:35, Yaron wrote:
> That link doesn't work for me. Wrong #?
> 
> And ya, seems pretty inefficient as is and belongs in gyp

Done.

https://codereview.chromium.org/13261024/diff/1008/build/android/write_ordere...
build/android/write_ordered_libraries.py:28: options = None
On 2013/04/02 01:30:35, Yaron wrote:
> globals should be prefixed with "_"

Done.

https://codereview.chromium.org/13261024/diff/1008/build/android/write_ordere...
build/android/write_ordered_libraries.py:46: def GetDependencies(library_name):
On 2013/04/02 01:30:35, Yaron wrote:
> GetNonSystemLibraryDependencies

Done.

https://codereview.chromium.org/13261024/diff/1008/build/android/write_ordere...
build/android/write_ordered_libraries.py:48: library_re = re.compile(
On 2013/04/02 01:30:35, Yaron wrote:
> compile this once at module level

Done.

https://codereview.chromium.org/13261024/diff/1008/build/android/write_ordere...
build/android/write_ordered_libraries.py:51: return set([lib for lib in matches
if not IsSystemLibrary(lib)])
On 2013/04/02 01:30:35, Yaron wrote:
> If you're always excluding system libraries, how are they pushed/bundled into
> the apk?

Added this to the file-level comment. System libraries are included with the
system and not bundled in the APK.

https://codereview.chromium.org/13261024/diff/1008/build/android/write_ordere...
build/android/write_ordered_libraries.py:72: for (library, dependencies) in
unsorted_deps.items():
On 2013/04/02 01:30:35, Yaron wrote:
> nit: no parens

Done.

https://codereview.chromium.org/13261024/diff/1008/build/android/write_ordere...
build/android/write_ordered_libraries.py:85: parser.add_option('--readelf')
On 2013/04/02 01:30:35, Yaron wrote:
> Add help

Done.

https://codereview.chromium.org/13261024/diff/1008/build/java_apk.gypi
File build/java_apk.gypi (right):

https://codereview.chromium.org/13261024/diff/1008/build/java_apk.gypi#newcod...
build/java_apk.gypi:154: # TODO(cjhopman): Do we need to use readelf from the
android toolchain?
On 2013/04/02 01:30:35, Yaron wrote:
> Let's. android_toolchain should give you what you want.

Done.

[Yaron, 2013-04-02 21:00:41]

lgtm

https://codereview.chromium.org/13261024/diff/1008/build/android/setup.gyp
File build/android/setup.gyp (right):

https://codereview.chromium.org/13261024/diff/1008/build/android/setup.gyp#ne...
build/android/setup.gyp:17:
'<(DEPTH)/third_party/android_tools/ndk/sources/cxx-stl/stlport/libs/<(android_app_abi)/libstlport_shared.so',
On 2013/04/02 20:47:31, cjhopman wrote:
> On 2013/04/02 01:30:35, Yaron wrote:
> > Can you add a comment to build/common.gypi where the include paths are set
to
> > mention that this needs to be updated accordingly.
> 
> I've refactored common.gypi so that any changes to the stlport/libstdc++
> directories should only be needed in one place.

Nice

https://codereview.chromium.org/13261024/diff/1008/build/android/write_ordere...
File build/android/write_ordered_libraries.py (right):

https://codereview.chromium.org/13261024/diff/1008/build/android/write_ordere...
build/android/write_ordered_libraries.py:51: return set([lib for lib in matches
if not IsSystemLibrary(lib)])
On 2013/04/02 20:47:31, cjhopman wrote:
> On 2013/04/02 01:30:35, Yaron wrote:
> > If you're always excluding system libraries, how are they pushed/bundled
into
> > the apk?
> 
> Added this to the file-level comment. System libraries are included with the
> system and not bundled in the APK.

Heh, of course. So you don't need to System.loadLibrary them either? dalvik will
find them?

[cjhopman, 2013-04-02 21:17:40]

On 2013/04/02 21:00:41, Yaron wrote:
> Heh, of course. So you don't need to System.loadLibrary them either? dalvik
will
> find them?

Exactly.

[commit-bot: I haz the power, 2013-04-02 21:17:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cjhopman@chromium.org/13261024/21001

[commit-bot: I haz the power, 2013-04-03 02:35:41]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-04-03 15:40:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cjhopman@chromium.org/13261024/21001

[commit-bot: I haz the power, 2013-04-03 18:20:24]

Change committed as 192103