Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Unified Diff: pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart

Issue 1325843003: Add optional message to assert in Dart2js. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Reintroduce assertHelper for asserts without messages. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart
diff --git a/pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart b/pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart
index fce11790003dacfdbad320ee273c2e431740c833..5e15a7dcd36af84a8d024e69fe8af6d73f6f2fbb 100644
--- a/pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart
+++ b/pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart
@@ -27,14 +27,6 @@ abstract class ErrorBulkMixin<R, A>
}
@override
- R errorInvalidAssert(
- Send node,
- NodeList arguments,
- A arg) {
- return bulkHandleError(node, null, arg);
- }
-
- @override
R errorNonConstantConstructorInvoke(
NewExpression node,
Element element,
@@ -2943,14 +2935,6 @@ abstract class BaseBulkMixin<R, A>
}
@override
- R visitAssert(
- Send node,
- Node expression,
- A arg) {
- return bulkHandleNode(node, 'Assert `#` unhandled.', arg);
- }
-
- @override
R visitIs(
Send node,
Node expression,
@@ -4535,15 +4519,6 @@ class TraversalSendMixin<R, A> implements SemanticSendVisitor<R, A> {
}
@override
- R visitAssert(
- Send node,
- Node expression,
- A arg) {
- apply(expression, arg);
- return null;
- }
-
- @override
R visitBinary(
Send node,
Node left,

Powered by Google App Engine
This is Rietveld 408576698