pkg/compiler/lib/src/common/codegen.dart - Issue 1325843003: Add optional message to assert in Dart2js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/common/codegen.dart

Issue 1325843003: Add optional message to assert in Dart2js. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Reintroduce assertHelper for asserts without messages. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/common/codegen.dart

diff --git a/pkg/compiler/lib/src/common/codegen.dart b/pkg/compiler/lib/src/common/codegen.dart

index 323822b1f470af3b979468aa28a9c3f34b3cbaf3..002589cd6e90d912748da6f2830e7e73b28f42ca 100644

--- a/pkg/compiler/lib/src/common/codegen.dart

+++ b/pkg/compiler/lib/src/common/codegen.dart

@@ -56,6 +56,15 @@ class CodegenRegistry extends Registry {

CodegenEnqueuer get world => compiler.enqueuer.codegen;

JavaScriptBackend get backend => compiler.backend;

+ void registerAssert(bool hasMessage) {

+ if (hasMessage) {

+ registerStaticInvocation(backend.assertTestMethod);

+ registerStaticInvocation(backend.assertThrowMethod);

+ } else {

+ registerStaticInvocation(backend.assertHelperMethod);

+ }

void registerDependency(Element element) {

treeElements.registerDependency(element);

}