Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 1325783003: [DevTools] Added RemoteArray and RemoteFunction wrappers (Closed)

Created:
5 years, 3 months ago by kozy
Modified:
5 years, 3 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Added RemoteArray and RemoteFunction wrappers RemoteArray wrapper incapsulates at and length methods. RemoteFunction incapsulates targetFunction method. Wrappers have createFromObject methods which check type of object. In utilities.js method storeResultTo is added to Promise.prototype. This method allow to save promise result value to object[propertyName] and return it for following processing. BUG=61643 R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201653

Patch Set 1 #

Patch Set 2 : Added methods #

Patch Set 3 : #

Total comments: 6

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -7 lines) Patch
M Source/devtools/front_end/platform/utilities.js View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
M Source/devtools/front_end/sdk/RemoteObject.js View 1 2 3 7 chunks +186 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
kozy
Pavel, please take a look.
5 years, 3 months ago (2015-09-01 02:42:44 UTC) #1
kozy
Pavel, ptal, ready for review!
5 years, 3 months ago (2015-09-01 21:26:24 UTC) #2
pfeldman
lgtm https://codereview.chromium.org/1325783003/diff/40001/Source/devtools/front_end/platform/utilities.js File Source/devtools/front_end/platform/utilities.js (right): https://codereview.chromium.org/1325783003/diff/40001/Source/devtools/front_end/platform/utilities.js#newcode1510 Source/devtools/front_end/platform/utilities.js:1510: function storeResultTo(object, propertyName, result) { { goes next ...
5 years, 3 months ago (2015-09-02 03:05:52 UTC) #3
kozy
All done. https://codereview.chromium.org/1325783003/diff/40001/Source/devtools/front_end/platform/utilities.js File Source/devtools/front_end/platform/utilities.js (right): https://codereview.chromium.org/1325783003/diff/40001/Source/devtools/front_end/platform/utilities.js#newcode1510 Source/devtools/front_end/platform/utilities.js:1510: function storeResultTo(object, propertyName, result) { On 2015/09/02 ...
5 years, 3 months ago (2015-09-02 16:34:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1325783003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1325783003/80001
5 years, 3 months ago (2015-09-02 16:34:15 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 17:32:37 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201653

Powered by Google App Engine
This is Rietveld 408576698