Android: Enable a bunch of InProcessBrowserLayoutTests.

Android: Enable a bunch of InProcessBrowserLayoutTests.
    
Also allow multi level nested loops. number of passing tests: 108-->200

BUG=138275
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191903

[Yaron, 2013-04-02 01:54:43]

https://codereview.chromium.org/13257008/diff/13001/build/android/pylib/gtest...
File build/android/pylib/gtest/filter/content_browsertests_disabled (right):

https://codereview.chromium.org/13257008/diff/13001/build/android/pylib/gtest...
build/android/pylib/gtest/filter/content_browsertests_disabled:19:
IndexedDBLayoutTest.BasicTests
Does this mean we can remove IndexedDBTest now?

https://codereview.chromium.org/13257008/diff/13001/build/android/pylib/gtest...
build/android/pylib/gtest/filter/content_browsertests_disabled:29:
MediaLayoutTest.VideoAutoplayTest
If we fix this, we'd probbably be able to get rid of VideoTest.java (which is
flaky)

https://codereview.chromium.org/13257008/diff/13001/build/android/pylib/gtest...
File build/android/pylib/gtest/test_runner.py (right):

https://codereview.chromium.org/13257008/diff/13001/build/android/pylib/gtest...
build/android/pylib/gtest/test_runner.py:134: def
_GetOptionalDataFilesForTestSuite(test_suite_basename):
Why are these optional? Why might they not exist? Are they not always checked
out? This seems a bit too indeterminate and could lead to hard to diagnose
failures.

https://codereview.chromium.org/13257008/diff/13001/build/android/pylib/gtest...
build/android/pylib/gtest/test_runner.py:143: if test_suite_basename ==
'content_browsertests':
How much data does this end up copying?

https://codereview.chromium.org/13257008/diff/13001/build/android/pylib/gtest...
build/android/pylib/gtest/test_runner.py:228: self.adb.WaitForSdCardReady(20)
Maybe you should also be waiting for sd card to be ready? Are you guaranteeing
that anyone with optional data would have mandatory data?

https://codereview.chromium.org/13257008/diff/13001/build/android/pylib/gtest...
build/android/pylib/gtest/test_runner.py:235: if os.path.exists(data):
At least output what paths are being skipped, if any

[nilesh, 2013-04-02 17:04:01]

https://codereview.chromium.org/13257008/diff/13001/build/android/pylib/gtest...
File build/android/pylib/gtest/filter/content_browsertests_disabled (right):

https://codereview.chromium.org/13257008/diff/13001/build/android/pylib/gtest...
build/android/pylib/gtest/filter/content_browsertests_disabled:29:
MediaLayoutTest.VideoAutoplayTest
On 2013/04/02 01:54:43, Yaron wrote:
> If we fix this, we'd probbably be able to get rid of VideoTest.java (which is
> flaky)
I will look into fixing these and removing the java ones.

https://codereview.chromium.org/13257008/diff/13001/build/android/pylib/gtest...
File build/android/pylib/gtest/test_runner.py (right):

https://codereview.chromium.org/13257008/diff/13001/build/android/pylib/gtest...
build/android/pylib/gtest/test_runner.py:134: def
_GetOptionalDataFilesForTestSuite(test_suite_basename):
On 2013/04/02 01:54:43, Yaron wrote:
> Why are these optional? Why might they not exist? Are they not always checked
> out? This seems a bit too indeterminate and could lead to hard to diagnose
> failures.

On the svn workflow these directories do not exist (i.e. on the bots, the data
is in content/test/data). For git checkouts we need to push these
directories instead. The code checks for the data in content/test/data first and
then in "third_party/WebKit/LayoutTests" 
https://code.google.com/p/chromium/codesearch#chromium/src/content/public/com...
https://code.google.com/p/chromium/issues/detail?id=105104

Added bug reference in a comment.

https://codereview.chromium.org/13257008/diff/13001/build/android/pylib/gtest...
build/android/pylib/gtest/test_runner.py:143: if test_suite_basename ==
'content_browsertests':
On 2013/04/02 01:54:43, Yaron wrote:
> How much data does this end up copying?

less than 50MB (but only when someone is trying to run content_browsertests
locally). These do not exist on the bots.

https://codereview.chromium.org/13257008/diff/13001/build/android/pylib/gtest...
build/android/pylib/gtest/test_runner.py:228: self.adb.WaitForSdCardReady(20)
On 2013/04/02 01:54:43, Yaron wrote:
> Maybe you should also be waiting for sd card to be ready? Are you guaranteeing
> that anyone with optional data would have mandatory data?

Done.

https://codereview.chromium.org/13257008/diff/13001/build/android/pylib/gtest...
build/android/pylib/gtest/test_runner.py:235: if os.path.exists(data):
On 2013/04/02 01:54:43, Yaron wrote:
> At least output what paths are being skipped, if any
These will always be ignored on the bots.

[Yaron, 2013-04-02 17:13:51]

lgtm

[commit-bot: I haz the power, 2013-04-02 17:53:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/13257008/22001

[commit-bot: I haz the power, 2013-04-02 21:42:37]

Change committed as 191903

[jam, 2013-04-02 23:19:32]

sweet!