Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Unified Diff: components/html_viewer/web_graphics_context_3d_command_buffer_impl.cc

Issue 1325433003: command_buffer: Add support for creating non-WebGL ES 3 contexts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: missing hunk Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/client/compositor/blimp_context_provider.cc ('k') | gpu/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/html_viewer/web_graphics_context_3d_command_buffer_impl.cc
diff --git a/components/html_viewer/web_graphics_context_3d_command_buffer_impl.cc b/components/html_viewer/web_graphics_context_3d_command_buffer_impl.cc
index 52881c0157c0f906308221ed0b7c95a58aede588..6348fb9123b5f1a25e9af3effdf11cafd91f8bed 100644
--- a/components/html_viewer/web_graphics_context_3d_command_buffer_impl.cc
+++ b/components/html_viewer/web_graphics_context_3d_command_buffer_impl.cc
@@ -32,15 +32,7 @@ WebGraphicsContext3DCommandBufferImpl::WebGraphicsContext3DCommandBufferImpl(
// TODO(penghuang): Support share context.
// TODO(penghuang): Fill gl_info.
gpu::gles2::ContextCreationAttribHelper attrib_helper;
- attrib_helper.alpha_size = attributes.alpha ? 8 : 0;
- attrib_helper.depth_size = attributes.depth ? 24 : 0;
- attrib_helper.stencil_size = attributes.stencil ? 8 : 0;
- attrib_helper.samples = attributes.antialias ? 4 : 0;
- attrib_helper.sample_buffers = attributes.antialias ? 1 : 0;
- attrib_helper.fail_if_major_perf_caveat =
- attributes.failIfMajorPerformanceCaveat;
- attrib_helper.bind_generates_resource = false;
- attrib_helper.webgl_version = attributes.webGLVersion;
+ ConvertAttributes(attributes, &attrib_helper);
std::vector<int32_t> attrib_vector;
attrib_helper.Serialize(&attrib_vector);
gles2_context_ = MojoGLES2CreateContext(
« no previous file with comments | « blimp/client/compositor/blimp_context_provider.cc ('k') | gpu/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698