Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 13244003: Fixed typed_data_test to use correct object (Closed)

Created:
7 years, 8 months ago by vsm
Modified:
7 years, 8 months ago
Reviewers:
sra1, siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixed typed_data_test to use correct object Working on getting this to pass with dart2js. The view constructor is typed to take a ByteBuffer, not a *List type. Committed: https://code.google.com/p/dart/source/detail?r=20656

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tests/standalone/typed_data_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
vsm
7 years, 8 months ago (2013-03-28 22:40:41 UTC) #1
siva
lgtm
7 years, 8 months ago (2013-03-28 23:24:43 UTC) #2
vsm
7 years, 8 months ago (2013-03-28 23:51:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20656 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698