Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 13234002: Add helper gypi for predexing of prebuilt jars. (Closed)

Created:
7 years, 9 months ago by nyquist
Modified:
7 years, 9 months ago
Reviewers:
cjhopman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add helper gypi for predexing of prebuilt jars. After https://codereview.chromium.org/12913009/ landed we need to change the gyp targets that include prebuilt jars. Some of these live in external repositories. This adds a helper gypi for those targets so they are configured correctly. This should also make it easier going forward to update such targets. BUG=158821, 224600 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191299

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed quoting to support spaces in jar path #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -0 lines) Patch
A build/java_prebuilt.gypi View 1 1 chunk +59 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nyquist
cjhopman: PTAL
7 years, 9 months ago (2013-03-28 21:11:15 UTC) #1
cjhopman
lgtm https://codereview.chromium.org/13234002/diff/1/build/java_prebuilt.gypi File build/java_prebuilt.gypi (right): https://codereview.chromium.org/13234002/diff/1/build/java_prebuilt.gypi#newcode52 build/java_prebuilt.gypi:52: '--ignore=>!(echo >(_inputs) | md5sum)', The ">(_inputs)" needs to ...
7 years, 9 months ago (2013-03-28 21:17:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/13234002/5001
7 years, 9 months ago (2013-03-28 21:25:39 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 9 months ago (2013-03-29 03:09:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/13234002/5001
7 years, 9 months ago (2013-03-29 03:51:21 UTC) #5
commit-bot: I haz the power
7 years, 9 months ago (2013-03-29 04:57:00 UTC) #6
Message was sent while issue was closed.
Change committed as 191299

Powered by Google App Engine
This is Rietveld 408576698