Instant: Use Local NTP in non-incognito whenever possible.

Instant: Use Local NTP in non-incognito whenever possible.

BUG=224946
R=shishir@chromium.org
TEST=See bug.


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191431

[sreeram, 2013-03-29 17:01:06]

Please review.

[Shishir, 2013-03-29 17:14:46]

The description is somewhat confusing. Instead of local ntp, you probably want
to say NTP4 or non-extended-local ntp.

[sreeram, 2013-03-29 17:23:15]

On 2013/03/29 17:14:46, Shishir wrote:
> The description is somewhat confusing. Instead of local ntp, you probably want
> to say NTP4 or non-extended-local ntp.

No, the Local NTP is indeed the Instant Extended offline fallback NTP. The old
NTP is NTP4.

I've been trying to use these terms consistently:
Google NTP versus Local NTP versus NTP4.
Google overlay versus Local overlay versus Omnibox dropdown.

[Shishir, 2013-03-29 17:37:38]

On 2013/03/29 17:23:15, sreeram wrote:
> On 2013/03/29 17:14:46, Shishir wrote:
> > The description is somewhat confusing. Instead of local ntp, you probably
want
> > to say NTP4 or non-extended-local ntp.
> 
> No, the Local NTP is indeed the Instant Extended offline fallback NTP. The old
> NTP is NTP4.
> 
> I've been trying to use these terms consistently:
> Google NTP versus Local NTP versus NTP4.
> Google overlay versus Local overlay versus Omnibox dropdown.

I am a little confused. The first line of change in ReleaseNTPContents will
cause NTP4 to be used as the ntp in incognito instead of local NPT, wont it?

[sreeram, 2013-03-29 17:45:52]

On 2013/03/29 17:37:38, Shishir wrote:
> I am a little confused. The first line of change in ReleaseNTPContents will
> cause NTP4 to be used as the ntp in incognito instead of local NPT, wont it?

Yes. In Incognito, we'll use the NTP4 (i.e., the "beware of someone standing
behind you" NTP). We don't want to use the Local NTP in incognito. That is the
desired behaviour.

[Shishir, 2013-03-29 17:53:23]

lgtm

ok, got it. Was reading the wrong bug.

[commit-bot: I haz the power, 2013-03-29 17:56:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sreeram@chromium.org/13233003/1

[commit-bot: I haz the power, 2013-03-29 19:44:47]

Change committed as 191431