Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Unified Diff: ui/views/bubble/bubble_delegate_unittest.cc

Issue 13227002: Revise NativeWidgetWin focus hack; force focus on restore. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Keep BrowserFocusTest.BrowsersRememberFocus disabled. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/bubble/bubble_delegate_unittest.cc
diff --git a/ui/views/bubble/bubble_delegate_unittest.cc b/ui/views/bubble/bubble_delegate_unittest.cc
index 919166632468c8a377eb7db6e452dbc672f00c10..b9d6574d31007c5c684169df38f32d751fa3ce9c 100644
--- a/ui/views/bubble/bubble_delegate_unittest.cc
+++ b/ui/views/bubble/bubble_delegate_unittest.cc
@@ -176,14 +176,8 @@ TEST_F(BubbleDelegateTest, InitiallyFocusedView) {
Widget* bubble_widget = BubbleDelegateView::CreateBubble(bubble_delegate);
bubble_widget->Show();
- View* expected_view = bubble_delegate->GetInitiallyFocusedView();
- // TODO(ben|msw): The NativeWidgetWin::RestoreFocusOnActivate() workaround for
- // http://crbug.com/125976 breaks this simple test by clearing proper focus.
-#if defined(OS_WIN) && !defined(USE_AURA)
- expected_view = NULL;
-#endif
-
- EXPECT_EQ(expected_view, bubble_widget->GetFocusManager()->GetFocusedView());
+ EXPECT_EQ(bubble_delegate->GetInitiallyFocusedView(),
+ bubble_widget->GetFocusManager()->GetFocusedView());
bubble_widget->CloseNow();
}

Powered by Google App Engine
This is Rietveld 408576698