Bluetooth: remove private members from BluetoothAdapter

chrome/browser/extensions/api/bluetooth/bluetooth_event_router_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/bluetooth/bluetooth_event_router.h"
 #include "chrome/test/base/testing_profile.h"
 #include "device/bluetooth/test/mock_bluetooth_adapter.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
-namespace {
-
-const char* kAdapterAddress = "Mock Adapter address for testing";
-const char* kName = "Mock Adapter name for testing";
-
-}  // namespace
-
 namespace extensions {
 
 class ExtensionBluetoothEventRouterTest : public testing::Test {
  public:
   ExtensionBluetoothEventRouterTest()

[Mark Mentovai, 2013/04/02 18:05:27]

This constructor should be explicit.

[keybuk, 2013/04/02 19:03:09]

I'm confused as to why this would be explicit?

explicit is meaningless for a constructor that has no arguments, since it would
never be involved in an implicit conversion ?

[Mark Mentovai, 2013/04/02 19:30:24]

keybuk wrote:
Yes, this was a mistake.

-      : mock_adapter_(new testing::StrictMock<device::MockBluetoothAdapter>(
-            kAdapterAddress, kName)),
+      : mock_adapter_(new testing::StrictMock<device::MockBluetoothAdapter>),

[youngki, 2013/04/02 12:30:31]

put parentheses () .

[Mark Mentovai, 2013/04/02 18:05:27]

Nobody deletes this?

[keybuk, 2013/04/02 19:03:09]

Done.

         router_(&test_profile_) {
     router_.SetAdapterForTest(mock_adapter_);
   }
 
  protected:
   testing::StrictMock<device::MockBluetoothAdapter>* mock_adapter_;
   TestingProfile test_profile_;
   ExtensionBluetoothEventRouter router_;
 };
 
 TEST_F(ExtensionBluetoothEventRouterTest, BluetoothEventListener) {
   router_.OnListenerAdded();
   EXPECT_CALL(*mock_adapter_, RemoveObserver(testing::_)).Times(1);
   router_.OnListenerRemoved();
 }
 
 TEST_F(ExtensionBluetoothEventRouterTest, MultipleBluetoothEventListeners) {
   router_.OnListenerAdded();
   router_.OnListenerAdded();
   router_.OnListenerAdded();
   router_.OnListenerRemoved();
   router_.OnListenerRemoved();
   EXPECT_CALL(*mock_adapter_, RemoveObserver(testing::_)).Times(1);
   router_.OnListenerRemoved();
 }
 
 }  // namespace extensions