Issue 13222004: Trim the copy of the dst made for dst-reading effects using the clip and dev-bounds of draw.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13222004: Trim the copy of the dst made for dst-reading effects using the clip and dev-bounds of draw. (Closed)

Created:
7 years, 8 months ago by bsalomon

Modified:
7 years, 8 months ago

Reviewers:
jvanverth1, robertphilips, robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Trim the copy of the dst made for dst-reading effects using the clip and dev-bounds of draw. Adds dev bounds to circles and rects drawn by GrDrawTarget base class (GrIODB already provides rect bounds). Committed: http://code.google.com/p/skia/source/detail?r=8453

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -33 lines)			Patch
M	include/core/SkTLazy.h	View	1	1 chunk	+8 lines, -2 lines	0 comments	Download
M	src/gpu/GrDrawState.h	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/gpu/GrDrawTarget.h	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/gpu/GrDrawTarget.cpp	View	1 2	5 chunks	+33 lines, -17 lines	0 comments	Download
M	src/gpu/GrOvalRenderer.cpp	View	1 2	1 chunk	+11 lines, -14 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bsalomon

Not as much of a speedup as I had hoped. Shaves 7 gmsecs off the ...

7 years, 8 months ago (2013-03-30 17:05:46 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/13222004/7002

7 years, 8 months ago (2013-04-01 12:47:19 UTC) #3

Message was sent while issue was closed.

Change committed as 8453

Expand Messages | Collapse Messages