Issue 13219004: Set pepper flash fullscreen window to opaque.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13219004: Set pepper flash fullscreen window to opaque. (Closed)

Created:
7 years, 8 months ago by jbauman

Modified:
7 years, 8 months ago

Reviewers:
Ken Russell (switch to Gerrit), Nico

CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, sail+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Set pepper flash fullscreen window to opaque. CGLFlushDrawable was taking a really long time when presenting to a fullscreen pepper flash window when using a discrete GPU while the Chrome window was also being drawn to. Setting the window to opaque seems to fix that, and still works because the GL content is always drawn on top of the Flash window, and not underneath. BUG=171911 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191271

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	content/browser/renderer_host/render_widget_host_view_mac.mm	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/13219004/1

7 years, 8 months ago (2013-03-28 21:07:13 UTC) #3

Message was sent while issue was closed.

LGTM also FWIW.

Expand Messages | Collapse Messages