gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc - Issue 1320093002: Command Buffer: read pixels into pixel pack buffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc

Issue 1320093002: Command Buffer: read pixels into pixel pack buffer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed zmo@'s feedback: should use different functions to get pixels size Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc

diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc

index b14913504927a77a807c073fa8a53a71b4a27830..25132795648fc0975d10c1226f10a5a4a519e32b 100644

--- a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc

+++ b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc

@@ -831,6 +831,17 @@ void GLES2DecoderTestBase::DoBindBuffer(

EXPECT_CALL(*gl_, BindBuffer(target, service_id))

.Times(1)

.RetiresOnSaturation();

+ if (target == GL_PIXEL_PACK_BUFFER) {

+ EXPECT_CALL(*gl_, PixelStorei(GL_PACK_ROW_LENGTH, _))

+ .Times(1)

+ .RetiresOnSaturation();

+ EXPECT_CALL(*gl_, PixelStorei(GL_PACK_SKIP_PIXELS, _))

+ .Times(1)

+ .RetiresOnSaturation();

+ EXPECT_CALL(*gl_, PixelStorei(GL_PACK_SKIP_ROWS, _))

+ .Times(1)

+ .RetiresOnSaturation();

+ }

cmds::BindBuffer cmd;

cmd.Init(target, client_id);

EXPECT_EQ(error::kNoError, ExecuteCmd(cmd));