Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3049)

Unified Diff: Source/web/FrameLoaderClientImpl.cpp

Issue 1319863006: (blink) Propagate scrolling/marginwidth/marginheight property values to child frame. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: address comments + static_cast for enum conversion Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/FrameLoaderClientImpl.cpp
diff --git a/Source/web/FrameLoaderClientImpl.cpp b/Source/web/FrameLoaderClientImpl.cpp
index 0e82d6c77fc15e7d285dc4ff87773f9a1917b6a1..e18d645618530f92498ae8c41c1b754189cfd494 100644
--- a/Source/web/FrameLoaderClientImpl.cpp
+++ b/Source/web/FrameLoaderClientImpl.cpp
@@ -187,6 +187,26 @@ void FrameLoaderClientImpl::didChangeScrollOffset()
webview->devToolsEmulator()->viewportChanged();
}
+void FrameLoaderClientImpl::didChangeScrollingMode(Frame* childFrame, ScrollbarMode scrollingMode)
alexmos 2015/09/02 21:37:05 Nit: move these down to didChangeName and DidChang
lazyboy 2015/09/15 01:40:33 Done.
+{
+ if (!m_webFrame->client())
+ return;
+
+ m_webFrame->client()->didChangeScrollingMode(WebFrame::fromFrame(childFrame), static_cast<WebFrameOwnerProperties::ScrollingMode>(scrollingMode));
+}
+
+void FrameLoaderClientImpl::didChangeMarginWidth(Frame* childFrame, int newMarginWidth)
+{
+ if (m_webFrame->client())
+ m_webFrame->client()->didChangeMarginWidth(WebFrame::fromFrame(childFrame), newMarginWidth);
+}
+
+void FrameLoaderClientImpl::didChangeMarginHeight(Frame* childFrame, int newMarginHeight)
+{
+ if (m_webFrame->client())
+ m_webFrame->client()->didChangeMarginHeight(WebFrame::fromFrame(childFrame), newMarginHeight);
+}
+
void FrameLoaderClientImpl::didUpdateCurrentHistoryItem()
{
if (m_webFrame->client())

Powered by Google App Engine
This is Rietveld 408576698