Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Unified Diff: public/web/WebFrameClient.h

Issue 1319863006: (blink) Propagate scrolling/marginwidth/marginheight property values to child frame. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/web/WebFrameClient.h
diff --git a/public/web/WebFrameClient.h b/public/web/WebFrameClient.h
index c77a394480bee1982c3a71cc3d41637ba68c01b0..88d3ab031a3f540d3494ca8044fb906c3294adef 100644
--- a/public/web/WebFrameClient.h
+++ b/public/web/WebFrameClient.h
@@ -36,6 +36,7 @@
#include "WebDOMMessageEvent.h"
#include "WebDataSource.h"
#include "WebFrame.h"
+#include "WebFrameOwnerProperties.h"
#include "WebHistoryCommitType.h"
#include "WebHistoryItem.h"
#include "WebIconURL.h"
@@ -149,7 +150,7 @@ public:
// until frameDetached() is called on it.
// Note: If you override this, you should almost certainly be overriding
// frameDetached().
- virtual WebFrame* createChildFrame(WebLocalFrame* parent, WebTreeScopeType, const WebString& frameName, WebSandboxFlags sandboxFlags) { return nullptr; }
+ virtual WebFrame* createChildFrame(WebLocalFrame* parent, WebTreeScopeType, const WebString& frameName, WebSandboxFlags sandboxFlags, const WebFrameOwnerProperties&) { return nullptr; }
// This frame set its opener to null, disowning it.
// See http://html.spec.whatwg.org/#dom-opener.
@@ -179,6 +180,15 @@ public:
// The sandbox flags have changed for a child frame of this frame.
virtual void didChangeSandboxFlags(WebFrame* childFrame, WebSandboxFlags flags) { }
+ // The "marginwidth" property has changed for a child frame of this frame.
+ virtual void didChangeMarginWidth(WebFrame* childFrame, int newMarginWidth) {}
+
+ // The "marginheight" property has changed for a child frame of this frame.
+ virtual void didChangeMarginHeight(WebFrame* childFrame, int newMarginHeight) {}
+
+ // The "scrolling" property has changed for a child frame of this frame.
+ virtual void didChangeScrollingMode(WebFrame* childFrame, WebFrameOwnerProperties::ScrollingMode) {}
+
// Called when a watched CSS selector matches or stops matching.
virtual void didMatchCSS(WebLocalFrame*, const WebVector<WebString>& newlyMatchingSelectors, const WebVector<WebString>& stoppedMatchingSelectors) { }

Powered by Google App Engine
This is Rietveld 408576698