Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Unified Diff: Source/core/frame/FrameView.cpp

Issue 1319863006: (blink) Propagate scrolling/marginwidth/marginheight property values to child frame. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: address nits Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/frame/FrameOwner.h ('k') | Source/core/frame/LocalFrame.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/FrameView.cpp
diff --git a/Source/core/frame/FrameView.cpp b/Source/core/frame/FrameView.cpp
index a956cd4ee393e62f18998302b8d94965cdf65e8a..5f40a693d7bdbb67b448efee63f4cabdb621b6b6 100644
--- a/Source/core/frame/FrameView.cpp
+++ b/Source/core/frame/FrameView.cpp
@@ -234,13 +234,8 @@ void FrameView::init()
m_size = LayoutSize();
// Propagate the marginwidth/height and scrolling modes to the view.
- // FIXME: Do we need to do this for OOPI?
- Element* ownerElement = m_frame->deprecatedLocalOwner();
- if (ownerElement && (isHTMLFrameElement(*ownerElement) || isHTMLIFrameElement(*ownerElement))) {
- HTMLFrameElementBase* frameElt = toHTMLFrameElementBase(ownerElement);
- if (frameElt->scrollingMode() == ScrollbarAlwaysOff)
- setCanHaveScrollbars(false);
- }
+ if (m_frame->owner() && m_frame->owner()->scrollingMode() == ScrollbarAlwaysOff)
+ setCanHaveScrollbars(false);
}
void FrameView::dispose()
@@ -588,9 +583,7 @@ void FrameView::applyOverflowToViewport(LayoutObject* o, ScrollbarMode& hMode, S
void FrameView::calculateScrollbarModesForLayout(ScrollbarMode& hMode, ScrollbarMode& vMode, ScrollbarModesCalculationStrategy strategy)
{
- // FIXME: How do we handle this for OOPI?
- const HTMLFrameOwnerElement* owner = m_frame->deprecatedLocalOwner();
- if (owner && (owner->scrollingMode() == ScrollbarAlwaysOff)) {
+ if (m_frame->owner() && m_frame->owner()->scrollingMode() == ScrollbarAlwaysOff) {
hMode = ScrollbarAlwaysOff;
vMode = ScrollbarAlwaysOff;
return;
« no previous file with comments | « Source/core/frame/FrameOwner.h ('k') | Source/core/frame/LocalFrame.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698