(blink) Propagate scrolling/marginwidth/marginheight property values to child frame.

Source/core/html/HTMLFrameOwnerElement.cpp

 /*
  * Copyright (C) 2006, 2007, 2009 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 90 matching lines @@
         return;
     }
     widgetNewParentMap().set(child, parent);
 }
 
 HTMLFrameOwnerElement::HTMLFrameOwnerElement(const QualifiedName& tagName, Document& document)
     : HTMLElement(tagName, document)
     , m_contentFrame(nullptr)
     , m_widget(nullptr)
     , m_sandboxFlags(SandboxNone)
+    , m_scrollingMode(ScrollbarAuto)
+    , m_marginWidth(-1)
+    , m_marginHeight(-1)
 {
 }
 
 LayoutPart* HTMLFrameOwnerElement::layoutPart() const
 {
     // HTMLObjectElement and HTMLEmbedElement may return arbitrary layoutObjects
     // when using fallback content.
     if (!layoutObject() || !layoutObject()->isLayoutPart())
         return nullptr;
     return toLayoutPart(layoutObject());
@@ skipping 62 matching lines @@
 
 void HTMLFrameOwnerElement::setSandboxFlags(SandboxFlags flags)
 {
     m_sandboxFlags = flags;
     // Don't notify about updates if contentFrame() is null, for example when
     // the subframe hasn't been created yet.
     if (contentFrame())
         document().frame()->loader().client()->didChangeSandboxFlags(contentFrame(), flags);
 }
 
+void HTMLFrameOwnerElement::setScrollingMode(ScrollbarMode scrollbarMode)
+{
+    m_scrollingMode = scrollbarMode;
+    // Don't notify about updates if contentFrame() is null, for example when
+    // the subframe hasn't been created yet.
+    if (contentFrame())
+        document().frame()->loader().client()->didChangeScrollingMode(contentFrame(), scrollbarMode);

[alexmos, 2015/09/02 21:37:05]

HTMLPlugInElement also inherits from HTMLFrameOwnerElement.  Do we need to
propagate these properties for that too, or just HTMLFrameElementBase?  If yes,
then createChildFrame needs to be fixed as well, since it currently checks
isHTMLFrameElementBase to propagate margins.

[lazyboy, 2015/09/15 01:40:32]

Since parseAttribute() in HTMLFrameElementBase was looking for these properties,
I'm guessing not. I don't see them here either:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/object
If yes,
I've made it not propagate updates if this is a plugin element.

[alexmos, 2015/09/16 00:36:47]

Acknowledged.

+}
+
+void HTMLFrameOwnerElement::setMarginWidth(int marginWidth)
+{
+    m_marginWidth = marginWidth;
+    // Don't notify about updates if contentFrame() is null, for example when
+    // the subframe hasn't been created yet.
+    if (contentFrame())
+        document().frame()->loader().client()->didChangeMarginWidth(contentFrame(), m_marginWidth);
+}
+
+void HTMLFrameOwnerElement::setMarginHeight(int marginHeight)
+{
+    m_marginHeight = marginHeight;
+    // Don't notify about updates if contentFrame() is null, for example when
+    // the subframe hasn't been created yet.
+    if (contentFrame())
+        document().frame()->loader().client()->didChangeMarginHeight(contentFrame(), m_marginHeight);
+}
+
 bool HTMLFrameOwnerElement::isKeyboardFocusable() const
 {
     return m_contentFrame && HTMLElement::isKeyboardFocusable();
 }
 
 void HTMLFrameOwnerElement::dispatchLoad()
 {
     dispatchEvent(Event::create(EventTypeNames::load));
 }
 
@@ skipping 64 matching lines @@
 DEFINE_TRACE(HTMLFrameOwnerElement)
 {
     visitor->trace(m_contentFrame);
     visitor->trace(m_widget);
     HTMLElement::trace(visitor);
     FrameOwner::trace(visitor);
 }
 
 
 } // namespace blink