Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1319523005: Embed DartPad in the top part of homepage (Closed)

Created:
5 years, 3 months ago by Kathy Walrath
Modified:
3 years, 10 months ago
Reviewers:
Shams
CC:
lukechurch, sethladd, devoncarew
Base URL:
https://github.com/dart-lang/www.dartlang.org.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Embed DartPad in the top part of homepage. You have to click to see the DartPad. That's intentional, to avoid possible delays. Better ideas for the code are welcome, but I'd rather publish and iterate than wait until the code is ideal. We intend to update the rest of the code on the page in future changes, and probably use embedded DartPad in more places on the homepage. Staged: https://homepage-newdp-dot-dart-lang.appspot.com/ R=shaza@google.com Committed: 80c8d3bb0b7e5d2d22ba863a75ae0db1b2b47c65

Patch Set 1 #

Patch Set 2 : Use new dartpad embed macro in streams tutorial #

Patch Set 3 : remove 2nd dartpad #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -23 lines) Patch
M src/site/_config.yml View 1 chunk +1 line, -1 line 0 comments Download
M src/site/css/dart-style.css View 2 chunks +6 lines, -1 line 0 comments Download
M src/site/docs/tutorials/streams/index.markdown View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/site/index.html View 1 2 2 chunks +56 lines, -18 lines 0 comments Download
A src/site/js/carousel-next.js View 1 chunk +5 lines, -0 lines 0 comments Download
A src/tests/site/gists/README.md View 1 chunk +39 lines, -0 lines 0 comments Download
A src/tests/site/gists/homepage_jw/pubspec.yaml View 1 chunk +6 lines, -0 lines 0 comments Download
A src/tests/site/gists/homepage_jw/web/main.dart View 1 chunk +19 lines, -0 lines 0 comments Download
A src/tests/site/gists/homepage_jw_html/pubspec.yaml View 1 chunk +17 lines, -0 lines 0 comments Download
A src/tests/site/gists/homepage_jw_html/web/index.html View 1 chunk +28 lines, -0 lines 0 comments Download
A src/tests/site/gists/homepage_jw_html/web/main.dart View 1 chunk +32 lines, -0 lines 0 comments Download
A src/tests/site/gists/homepage_jw_html/web/styles.css View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Kathy Walrath
5 years, 3 months ago (2015-08-25 21:31:49 UTC) #2
Shams
lgtm I think this looks great!!!!
5 years, 3 months ago (2015-08-25 21:44:46 UTC) #3
Kathy Walrath
5 years, 3 months ago (2015-08-26 13:46:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
80c8d3bb0b7e5d2d22ba863a75ae0db1b2b47c65 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698