Omnibox: Don't Promote Intranet Hostnames Pound Sign Space Whatever ("c# foo")

chrome/browser/autocomplete/history_url_provider_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autocomplete/history_url_provider.h"
 
 #include <algorithm>
 
 #include "base/file_util.h"
 #include "base/message_loop.h"
@@ skipping 147 matching lines @@
   }
   virtual void TearDown();
 
   // Does the real setup.
   void SetUpImpl(bool no_db);
 
   // Fills test data into the history system.
   void FillData();
 
   // Runs an autocomplete query on |text| and checks to see that the returned
-  // results' destination URLs match those provided.
+  // results' destination URLs match those provided.  Also allows checking
+  // that the input type was identified correctly.
   void RunTest(const string16 text,
                const string16& desired_tld,
                bool prevent_inline_autocomplete,
                const std::string* expected_urls,
-               size_t num_results);
+               size_t num_results,
+               AutocompleteInput::Type* identified_input_type);
+
+  // A version of the above without the final |type| output parameter.
+  void RunTest(const string16 text,
+               const string16& desired_tld,
+               bool prevent_inline_autocomplete,
+               const std::string* expected_urls,
+               size_t num_results) {
+    AutocompleteInput::Type type;
+    return RunTest(text, desired_tld, prevent_inline_autocomplete,
+                   expected_urls, num_results, &type);
+  }
 
   void RunAdjustOffsetTest(const string16 text, size_t expected_offset);
 
   MessageLoopForUI message_loop_;
   content::TestBrowserThread ui_thread_;
   content::TestBrowserThread file_thread_;
   ACMatches matches_;
   scoped_ptr<TestingProfile> profile_;
   HistoryService* history_service_;
   scoped_refptr<HistoryURLProvider> autocomplete_;
@@ skipping 49 matching lines @@
                                          history::SOURCE_BROWSED);
   }
 
   history_service_->AddPageWithDetails(
       GURL("http://p/"), UTF8ToUTF16("p"), 0, 0,
       Time::Now() -
       TimeDelta::FromDays(history::kLowQualityMatchAgeLimitInDays - 1),
       false, history::SOURCE_BROWSED);
 }
 
-void HistoryURLProviderTest::RunTest(const string16 text,
-                                     const string16& desired_tld,
-                                     bool prevent_inline_autocomplete,
-                                     const std::string* expected_urls,
-                                     size_t num_results) {
+void HistoryURLProviderTest::RunTest(
+    const string16 text,
+    const string16& desired_tld,
+    bool prevent_inline_autocomplete,
+    const std::string* expected_urls,
+    size_t num_results,
+    AutocompleteInput::Type* identified_input_type) {
   AutocompleteInput input(text, string16::npos, desired_tld, GURL(),
                           prevent_inline_autocomplete, false, true,
                           AutocompleteInput::ALL_MATCHES);
+  *identified_input_type = input.type();
   autocomplete_->Start(input, false);
   if (!autocomplete_->done())
     MessageLoop::current()->Run();
 
   matches_ = autocomplete_->matches();
   if (sort_matches_) {
     for (ACMatches::iterator i = matches_.begin(); i != matches_.end(); ++i)
       i->ComputeStrippedDestinationURL(profile_.get());
     std::sort(matches_.begin(), matches_.end(),
               &AutocompleteMatch::DestinationSortFunc);
@@ skipping 342 matching lines @@
       ASSERT_NO_FATAL_FAILURE(RunTest(ASCIIToUTF16(test_cases[i].input),
                               string16(), false, output, arraysize(output)));
       // Actual relevance should be at least what test_cases expects and
       // and no more than 10 more.
       EXPECT_LE(test_cases[i].relevance, matches_[0].relevance);
       EXPECT_LT(matches_[0].relevance, test_cases[i].relevance + 10);
     }
   }
 }
 
+TEST_F(HistoryURLProviderTest, IntranetURLsWithRefs) {
+  struct TestCase {
+    const char* input;
+    int relevance;
+    AutocompleteInput::Type type;
+  } test_cases[] = {
+    { "gooey", 1410, AutocompleteInput::UNKNOWN },
+    { "gooey/", 1410, AutocompleteInput::URL },
+    { "gooey#", 1200, AutocompleteInput::UNKNOWN },
+    { "gooey/#", 1200, AutocompleteInput::URL },
+    { "gooey#foo", 1200, AutocompleteInput::UNKNOWN },
+    { "gooey/#foo", 1200, AutocompleteInput::URL },
+    { "gooey# foo", 1200, AutocompleteInput::UNKNOWN },
+    { "gooey/# foo", 1200, AutocompleteInput::URL },
+  };
+  for (size_t i = 0; i < ARRAYSIZE_UNSAFE(test_cases); ++i) {
+    SCOPED_TRACE(test_cases[i].input);
+    const std::string output[] = {
+      URLFixerUpper::FixupURL(test_cases[i].input, std::string()).spec()
+    };
+    AutocompleteInput::Type type;
+    ASSERT_NO_FATAL_FAILURE(
+        RunTest(ASCIIToUTF16(test_cases[i].input),
+                string16(), false, output, arraysize(output), &type));
+    // Actual relevance should be at least what test_cases expects and
+    // and no more than 10 more.
+    EXPECT_LE(test_cases[i].relevance, matches_[0].relevance);
+    EXPECT_LT(matches_[0].relevance, test_cases[i].relevance + 10);
+    // Input type should be what we expect.  This is important because
+    // this provider counts on SearchProvider to give queries a relevance
+    // score >1200 for UNKNOWN inputs and <1200 for URL inputs.  (That's
+    // already tested in search_provider_unittest.cc.)  For this test
+    // here to test that the user sees the correct behavior, it needs
+    // to check that the input type was identified correctly.
+    EXPECT_EQ(test_cases[i].type, type);
+  }
+}
+
 // Makes sure autocompletion happens for intranet sites that have been
 // previoulsy visited.
 TEST_F(HistoryURLProviderTest, IntranetURLCompletion) {
   sort_matches_ = true;
 
   const std::string expected1[] = {
     "http://intra/three",
     "http://intra/two",
   };
   ASSERT_NO_FATAL_FAILURE(RunTest(ASCIIToUTF16("intra/t"), string16(), false,
@@ skipping 107 matching lines @@
   RunTest(ASCIIToUTF16("foobar"), string16(), true,
       expected_when_searching_query, arraysize(expected_when_searching_query));
 
   // We should not see search URLs when typing the search engine name.
   const std::string expected_when_searching_site[] = {
     test_cases[0].url
   };
   RunTest(ASCIIToUTF16("testsearch"), string16(), true,
       expected_when_searching_site, arraysize(expected_when_searching_site));
 }