Issue 13188002: android: Update comment about invalid timestamps from SurfaceFlinger

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13188002: android: Update comment about invalid timestamps from SurfaceFlinger (Closed)

Created:
7 years, 9 months ago by Sami

Modified:
7 years, 9 months ago

Reviewers:
bulach

CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

android: Update comment about invalid timestamps from SurfaceFlinger A frame with a timestamp of INT64_MAX actually means that the fence object associated with the frame is still pending or that the frame has not yet been displayed. Update the comment in SurfaceStatsCollector to make this more obvious. No functional changes. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191158

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -5 lines)			Patch
	M	build/android/pylib/surface_stats_collector.py	View		1 chunk	+6 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/13188002/1

7 years, 9 months ago (2013-03-28 16:22:10 UTC) #3

Message was sent while issue was closed.

Change committed as 191158

Expand Messages | Collapse Messages