Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Unified Diff: pkg/compiler/lib/src/js_backend/namer.dart

Issue 1318043005: Support user generated custom native JS classes. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: ptal Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/namer.dart
diff --git a/pkg/compiler/lib/src/js_backend/namer.dart b/pkg/compiler/lib/src/js_backend/namer.dart
index 6156b277c2107c48dd750947b0bb977e9ad7b05a..5b84c0e8e0c3fd99793513151005e5b59b9c080a 100644
--- a/pkg/compiler/lib/src/js_backend/namer.dart
+++ b/pkg/compiler/lib/src/js_backend/namer.dart
@@ -764,6 +764,7 @@ class Namer {
if (element.hasFixedBackendName) {
// Certain native fields must be given a specific name. Native names must
// not contain '$'. We rely on this to avoid clashes.
+ // TODO(jacobr): we need to relax this constraint.
assert(enclosingClass.isNative &&
!element.fixedBackendName.contains(r'$'));

Powered by Google App Engine
This is Rietveld 408576698