Issue 13177002: Remove push(holder_reg) in CheckAccessGlobalProxy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13177002: Remove push(holder_reg) in CheckAccessGlobalProxy. (Closed)

Created:
7 years, 9 months ago by Yang

Modified:
7 years, 8 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Remove push(holder_reg) in CheckAccessGlobalProxy. R=jkummerow@chromium.org BUG=v8:119 Committed: https://code.google.com/p/v8/source/detail?r=14150

Patch Set 2 : #

Created: 7 years, 8 months ago

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -35 lines)
M	src/arm/macro-assembler-arm.cc	View	2 chunks	+0 lines, -2 lines	0 comments
M	src/ia32/macro-assembler-ia32.h	View	1 chunk	+2 lines, -1 line	0 comments
M	src/ia32/macro-assembler-ia32.cc	View	1 chunk	+18 lines, -22 lines	0 comments
M	src/ia32/stub-cache-ia32.cc	View	5 chunks	+10 lines, -8 lines	0 comments
M	src/mips/macro-assembler-mips.cc	View	2 chunks	+0 lines, -2 lines	0 comments

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with a comment. https://codereview.chromium.org/13177002/diff/1/src/ia32/macro-assembler-ia32.cc File src/ia32/macro-assembler-ia32.cc (right): https://codereview.chromium.org/13177002/diff/1/src/ia32/macro-assembler-ia32.cc#newcode1053 src/ia32/macro-assembler-ia32.cc:1053: mov(scratch2, FieldOperand(scratch1, HeapObject::kMapOffset)); I think ...

7 years, 8 months ago (2013-04-01 12:06:06 UTC) #2

Yang

7 years, 8 months ago (2013-04-05 12:06:44 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r14150 (presubmit successful).

Expand Messages | Collapse Messages

Issue 13177002: Remove push(holder_reg) in CheckAccessGlobalProxy. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages