Issue 13170002: net: add GoogleG2 to allowed Google pins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13170002: net: add GoogleG2 to allowed Google pins. (Closed)

Created:
7 years, 9 months ago by agl

Modified:
7 years, 9 months ago

Reviewers:
palmer

CC:
chromium-reviews, cbentzel+watch_chromium.org, Ryan Sleevi

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

net: add GoogleG2 to allowed Google pins. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191212

Patch Set 1 #

Total comments: 2

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -0 lines)			Patch
M	net/http/transport_security_state_static.h	View	2 chunks	+5 lines, -0 lines	1 comment	Download
M	net/http/transport_security_state_static.certs	View	1 chunk	+3 lines, -0 lines	1 comment	Download
M	net/http/transport_security_state_static.json	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

palmer

lgtm https://codereview.chromium.org/13170002/diff/1/net/http/transport_security_state_static.certs File net/http/transport_security_state_static.certs (right): https://codereview.chromium.org/13170002/diff/1/net/http/transport_security_state_static.certs#newcode86 net/http/transport_security_state_static.certs:86: sha1/Q9rWMO5T+KmAym79hfRqo3mQ4Oo= As with the hex digest, my OpenSSL ...

7 years, 9 months ago (2013-03-28 18:24:10 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agl@chromium.org/13170002/1

7 years, 9 months ago (2013-03-28 18:27:58 UTC) #3

Message was sent while issue was closed.

Change committed as 191212

Expand Messages | Collapse Messages