Issue 13158002: Always allocate symbols in old space.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13158002: Always allocate symbols in old space. (Closed)

Created:
7 years, 9 months ago by Yang

Modified:
7 years, 9 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Always allocate symbols in old space. Keys are expected to be tenured. This now not only includes internalized strings, but also symbols. R=rossberg@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=14095

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comments #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -6 lines)			Patch
M	src/heap.h	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/heap.cc	View	1	2 chunks	+6 lines, -3 lines	0 comments	Download
M	test/mjsunit/harmony/symbols.js	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rossberg

LGTM with comments https://codereview.chromium.org/13158002/diff/1/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/13158002/diff/1/src/heap.cc#newcode5434 src/heap.cc:5434: AllocationSpace space = OLD_POINTER_SPACE; Nit: just ...

7 years, 9 months ago (2013-03-28 13:33:17 UTC) #2

Yang

7 years, 9 months ago (2013-03-28 13:52:40 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r14095 (presubmit successful).

Expand Messages | Collapse Messages