Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Side by Side Diff: Source/core/css/resolver/MatchedPropertiesCache.cpp

Issue 1315303010: Remove unused Element param from MatchedPropertiesCache::isCacheable (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
10 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 toRemove.append(cacheEntry.key); 136 toRemove.append(cacheEntry.key);
137 break; 137 break;
138 } 138 }
139 } 139 }
140 } 140 }
141 m_cache.removeAll(toRemove); 141 m_cache.removeAll(toRemove);
142 m_additionsSinceLastSweep = 0; 142 m_additionsSinceLastSweep = 0;
143 } 143 }
144 #endif 144 #endif
145 145
146 bool MatchedPropertiesCache::isCacheable(const Element* element, const ComputedS tyle& style, const ComputedStyle& parentStyle) 146 bool MatchedPropertiesCache::isCacheable(const ComputedStyle& style, const Compu tedStyle& parentStyle)
147 { 147 {
148 if (style.unique() || (style.styleType() != NOPSEUDO && parentStyle.unique() )) 148 if (style.unique() || (style.styleType() != NOPSEUDO && parentStyle.unique() ))
149 return false; 149 return false;
150 if (style.zoom() != ComputedStyle::initialZoom()) 150 if (style.zoom() != ComputedStyle::initialZoom())
151 return false; 151 return false;
152 if (style.writingMode() != ComputedStyle::initialWritingMode() || style.dire ction() != ComputedStyle::initialDirection()) 152 if (style.writingMode() != ComputedStyle::initialWritingMode() || style.dire ction() != ComputedStyle::initialDirection())
153 return false; 153 return false;
154 // The cache assumes static knowledge about which properties are inherited. 154 // The cache assumes static knowledge about which properties are inherited.
155 if (parentStyle.hasExplicitlyInheritedProperties()) 155 if (parentStyle.hasExplicitlyInheritedProperties())
156 return false; 156 return false;
157 return true; 157 return true;
158 } 158 }
159 159
160 DEFINE_TRACE(MatchedPropertiesCache) 160 DEFINE_TRACE(MatchedPropertiesCache)
161 { 161 {
162 #if ENABLE(OILPAN) 162 #if ENABLE(OILPAN)
163 visitor->trace(m_cache); 163 visitor->trace(m_cache);
164 #endif 164 #endif
165 } 165 }
166 166
167 } 167 }
OLDNEW
« no previous file with comments | « Source/core/css/resolver/MatchedPropertiesCache.h ('k') | Source/core/css/resolver/StyleResolver.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698