Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1214)

Unified Diff: content/public/browser/color_chooser.h

Issue 13150004: Support color chooser inside extesions, apps, chrome frame, dev tool (Closed) Base URL: http://git.chromium.org/chromium/src.git@ngcolor
Patch Set: Fixed android build Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/public/browser/web_contents.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/color_chooser.h
diff --git a/content/public/browser/color_chooser.h b/content/public/browser/color_chooser.h
index 9b0bf40f22bb22fdd248180c1c0c1027dd59026f..b40459192cf9a7189eff14aad69bbde38c1aec6d 100644
--- a/content/public/browser/color_chooser.h
+++ b/content/public/browser/color_chooser.h
@@ -9,36 +9,17 @@
namespace content {
-class WebContents;
-
-// Abstraction object for color choosers for each platform.
+// Interface for a color chooser.
class ColorChooser {
public:
- static ColorChooser* Create(int identifier,
- WebContents* web_contents,
- SkColor initial_color);
-
- explicit ColorChooser(int identifier) : identifier_(identifier) {}
virtual ~ColorChooser() {}
- // Returns a unique identifier for this chooser. Identifiers are unique
- // across a renderer process. This avoids race conditions in synchronizing
- // the browser and renderer processes. For example, if a renderer closes one
- // chooser and opens another, and simultaneously the user picks a color in the
- // first chooser, the IDs can be used to drop the "chose a color" message
- // rather than erroneously tell the renderer that the user picked a color in
- // the second chooser.
- int identifier() const { return identifier_; }
-
// Ends connection with color chooser. Closes color chooser depending on the
// platform.
virtual void End() = 0;
// Sets the selected color.
virtual void SetSelectedColor(SkColor color) = 0;
-
- private:
- int identifier_;
};
} // namespace content
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/public/browser/web_contents.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698