Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4703)

Unified Diff: chrome/browser/ui/browser.cc

Issue 13150004: Support color chooser inside extesions, apps, chrome frame, dev tool (Closed) Base URL: http://git.chromium.org/chromium/src.git@ngcolor
Patch Set: Fixed android build Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser.h ('k') | chrome/browser/ui/browser_dialogs.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index 90ef7d4ab7f10f27c435fce7cdab54af276e6f75..e4b14eadee08febb91bd853a3e028642d2b913c0 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -150,7 +150,6 @@
#include "chrome/common/startup_metric_utils.h"
#include "chrome/common/url_constants.h"
#include "components/web_modal/web_contents_modal_dialog_manager.h"
-#include "content/public/browser/color_chooser.h"
#include "content/public/browser/devtools_manager.h"
#include "content/public/browser/download_item.h"
#include "content/public/browser/download_manager.h"
@@ -596,8 +595,10 @@ void Browser::OnWindowClosing() {
bool should_quit_if_last_browser =
browser_shutdown::IsTryingToQuit() || !chrome::WillKeepAlive();
- if (should_quit_if_last_browser && chrome::ShouldStartShutdown(this))
+ if (should_quit_if_last_browser &&
+ BrowserList::GetInstance(host_desktop_type_)->size() == 1) {
browser_shutdown::OnShutdownStarting(browser_shutdown::WINDOW_CLOSE);
+ }
// Don't use GetForProfileIfExisting here, we want to force creation of the
// session service so that user can restore what was open.
@@ -1495,27 +1496,8 @@ content::JavaScriptDialogManager* Browser::GetJavaScriptDialogManager() {
}
content::ColorChooser* Browser::OpenColorChooser(WebContents* web_contents,
- int color_chooser_id,
- SkColor color) {
-#if defined(OS_WIN)
- // On Windows, only create a color chooser if one doesn't exist, because we
- // can't close the old color chooser dialog.
- if (!color_chooser_.get())
- color_chooser_.reset(content::ColorChooser::Create(color_chooser_id,
- web_contents,
- color));
-#else
- if (color_chooser_.get())
- color_chooser_->End();
- color_chooser_.reset(content::ColorChooser::Create(color_chooser_id,
- web_contents,
- color));
-#endif
- return color_chooser_.get();
-}
-
-void Browser::DidEndColorChooser() {
- color_chooser_.reset();
+ SkColor initial_color) {
+ return chrome::ShowColorChooser(web_contents, initial_color);
}
void Browser::RunFileChooser(WebContents* web_contents,
« no previous file with comments | « chrome/browser/ui/browser.h ('k') | chrome/browser/ui/browser_dialogs.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698