Stack trace API: poison stack frames below the first strict mode frame.

Stack trace API: poison stack frames below the first strict mode frame.

Function and receiver objects are not accessible for poisoned frames.

R=rossberg@chromium.org
BUG=v8:2564
Committed: https://code.google.com/p/v8/source/detail?r=14085

[rossberg, 2013-03-28 10:04:33]

LGTM with comments

https://codereview.chromium.org/13150003/diff/1/src/messages.js
File src/messages.js (right):

https://codereview.chromium.org/13150003/diff/1/src/messages.js#newcode755
src/messages.js:755: var CallSiteReceiverKey   = %CreateSymbol("receiver");
Nit: do our coding conventions allow this kind of spacing for alignment?

https://codereview.chromium.org/13150003/diff/1/src/messages.js#newcode768
src/messages.js:768: if (this[CallSiteStrictModeKey]) return void 0;
You could use ?: here.

https://codereview.chromium.org/13150003/diff/1/src/messages.js#newcode799
src/messages.js:799: if (this[CallSiteStrictModeKey]) return void 0;
...same here.

https://codereview.chromium.org/13150003/diff/1/src/messages.js#newcode1052
src/messages.js:1052: frames.push(new CallSite(recv, fun, pos, strict_mode));
Could inline def of strict_mode here.

https://codereview.chromium.org/13150003/diff/1/test/mjsunit/regress/regress-...
File test/mjsunit/regress/regress-2564.js (right):

https://codereview.chromium.org/13150003/diff/1/test/mjsunit/regress/regress-...
test/mjsunit/regress/regress-2564.js:34: Error.prepareStackTrace = undefined; 
// Prevent recursion.
Not sure I understand why this is necessary here. Should the below throw?

https://codereview.chromium.org/13150003/diff/1/test/mjsunit/regress/regress-...
test/mjsunit/regress/regress-2564.js:59: var o = [ function f0() { throw new
Error(); },
Maybe add a third test where the throwing function itself is strict.

[Yang, 2013-03-28 10:40:16]

Committed patchset #1 manually as r14085 (presubmit successful).

[Yang, 2013-03-28 10:55:03]

https://codereview.chromium.org/13150003/diff/1/test/mjsunit/regress/regress-...
File test/mjsunit/regress/regress-2564.js (right):

https://codereview.chromium.org/13150003/diff/1/test/mjsunit/regress/regress-...
test/mjsunit/regress/regress-2564.js:34: Error.prepareStackTrace = undefined; 
// Prevent recursion.
On 2013/03/28 10:04:33, rossberg wrote:
> Not sure I understand why this is necessary here. Should the below throw?

No, but if it does, i.e. assertion failure, the error message looks more sane.

https://codereview.chromium.org/13150003/diff/1/test/mjsunit/regress/regress-...
test/mjsunit/regress/regress-2564.js:59: var o = [ function f0() { throw new
Error(); },
On 2013/03/28 10:04:33, rossberg wrote:
> Maybe add a third test where the throwing function itself is strict.

Done.