Implement spawnDomUri.

tests/html/dom_isolates_test.dart

Index: tests/html/dom_isolates_test.dart
diff --git a/tests/html/dom_isolates_test.dart b/tests/html/dom_isolates_test.dart
index 7ce1386c25aa2ef3d63fe9509a02c81375602c4b..39092bc965510bfb08cf4b8e31327a1e06676de4 100644
--- a/tests/html/dom_isolates_test.dart
+++ b/tests/html/dom_isolates_test.dart
@@ -36,15 +36,19 @@ main() {
   useHtmlConfiguration();
 
   test('Simple DOM isolate test', () {
-    spawnDomFunction(childDomIsolate).then((sendPort) {
-      expect(sendPort.call('check'), completion('${window.location}'));
-    });
+    spawnDomFunction(childDomIsolate).then(expectAsync1(

[vsm, 2013/04/01 14:07:18]

I think expectAsync1 needs to be at the top-level to be effective.  E.g.,

final callback = expectAsync1(...);
spawnDomFunction(childDomIsolate).then(callback);

[Anton Muhin, 2013/04/01 14:18:17]

Sorry, I believe the main thing is we should not leave test callback before
expectAsync1 is invoked and that should be exactly the case:

spawnDomFunction returns immediately providing a future, now arguments of then
are evaluated leading to async callback registration, correct?

On 2013/04/01 14:07:18, vsm wrote:

[vsm, 2013/04/01 14:25:30]

I'm worried about the ordering:

(1) Test starts.
(2) spawnDomFunction executes, producing Future.
(3) Test completes and passes as no callbacks are yet expected.
(4) then clause executes, registering the expectAsync1 too late.

Isn't that a legal ordering as this test is written?

On 2013/04/01 14:18:17, Anton Muhin wrote:

[Anton Muhin, 2013/04/01 14:46:24]

I believe no. spawnDomFunction indeed produces a future, but doesn't stop here
and immediately invokes .then on it.  As part of .then invocation its arguments
are evaluated and closure is registered leading to marking the test as
asynchronous.

+        (sendPort) {
+            expect(sendPort.call('check'), completion('${window.location}'));
+        }
+    ));
   });
 
   test('Nested DOM isolates test', () {
-    spawnDomFunction(trampolineIsolate).then((sendPort) {
-      expect(sendPort.call('check'), completion('${window.location}'));
-    });
+    spawnDomFunction(trampolineIsolate).then(expectAsync1(

[vsm, 2013/04/01 14:07:18]

ditto

+        (sendPort) {
+            expect(sendPort.call('check'), completion('${window.location}'));
+        }
+    ));
   });
 
   test('Spawn DOM isolate from pure', () {
@@ -52,6 +56,14 @@ main() {
            completion('${window.location}'));
   });
 
+  test('Spawn DOM by uri', () {
+    spawnDomUri('dom_isolates_test.dart.child_isolate.dart').then(expectAsync1(

[vsm, 2013/04/01 14:07:18]

ditto

+        (sendPort) {
+            expect(sendPort.call('check'), completion('${window.location}'));
+        }
+    ));
+  });
+
   test('Not function', () {
       expect(() => spawnDomFunction(42), throws);
   });