Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6568)

Unified Diff: chrome/browser/ui/gtk/browser_window_gtk.cc

Issue 13139004: Deprecate Browser::TYPE_PANEL (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/browser_window_gtk.cc
diff --git a/chrome/browser/ui/gtk/browser_window_gtk.cc b/chrome/browser/ui/gtk/browser_window_gtk.cc
index d544767b31728ea7a142f599d3366f7f953fd3bf..aad04bce707ce9931ddd2ba9f66d47be520d54e7 100644
--- a/chrome/browser/ui/gtk/browser_window_gtk.cc
+++ b/chrome/browser/ui/gtk/browser_window_gtk.cc
@@ -306,7 +306,7 @@ void BrowserWindowGtk::Init() {
// popups need the widgets inited before they can set the window size
// properly. For other windows, we set the geometry first to prevent resize
// flicker.
- if (browser_->is_type_popup() || browser_->is_type_panel()) {
+ if (browser_->is_type_popup()) {
gtk_window_set_role(window_, "pop-up");
InitWidgets();
SetGeometryHints();
@@ -946,10 +946,6 @@ gfx::Rect BrowserWindowGtk::GetRootWindowResizerRect() const {
return gfx::Rect();
}
-bool BrowserWindowGtk::IsPanel() const {
- return false;
-}
-
void BrowserWindowGtk::ConfirmAddSearchProvider(TemplateURL* template_url,
Profile* profile) {
new EditSearchEngineDialog(window_, template_url, NULL, profile);
@@ -1532,12 +1528,11 @@ void BrowserWindowGtk::SetGeometryHints() {
//
// For popup windows, we assume that if x == y == 0, the opening page
// did not specify a position. Let the WM position the popup instead.
- bool is_popup_or_panel = browser_->is_type_popup() ||
- browser_->is_type_panel();
- bool popup_without_position = is_popup_or_panel &&
+ bool is_popup = browser_->is_type_popup();
+ bool popup_without_position = is_popup &&
bounds.x() == 0 && bounds.y() == 0;
bool move = browser_->bounds_overridden() && !popup_without_position;
- SetBoundsImpl(bounds, !is_popup_or_panel, move);
+ SetBoundsImpl(bounds, !is_popup, move);
}
void BrowserWindowGtk::ConnectHandlersToSignals() {

Powered by Google App Engine
This is Rietveld 408576698