Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: chrome/browser/ui/browser.cc

Issue 13139004: Deprecate Browser::TYPE_PANEL (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser.h ('k') | chrome/browser/ui/browser_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index 88b391a618c1768683dca430adf48e0a7a37b998..3520d667f189d7b968bab0f9ac1f1bacad07ce1e 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -422,16 +422,11 @@ Browser::Browser(const CreateParams& params)
// Set the app user model id for this application to that of the application
// name. See http://crbug.com/7028.
ui::win::SetAppIdForWindow(
- is_app() && !is_type_panel() ?
+ is_app() ?
ShellIntegration::GetAppModelIdForProfile(UTF8ToWide(app_name_),
profile_->GetPath()) :
ShellIntegration::GetChromiumModelIdForProfile(profile_->GetPath()),
window()->GetNativeWindow());
-
- if (is_type_panel()) {
- ui::win::SetAppIconForWindow(ShellIntegration::GetChromiumIconLocation(),
- window()->GetNativeWindow());
- }
#endif
// Create the extension window controller before sending notifications.
@@ -1342,8 +1337,7 @@ void Browser::MoveContents(WebContents* source, const gfx::Rect& pos) {
}
bool Browser::IsPopupOrPanel(const WebContents* source) const {
- // A non-tabbed BROWSER is an unconstrained popup.
- return is_type_popup() || is_type_panel();
+ return is_type_popup();
}
void Browser::UpdateTargetURL(WebContents* source, int32 page_id,
« no previous file with comments | « chrome/browser/ui/browser.h ('k') | chrome/browser/ui/browser_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698