Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: chrome/browser/extensions/window_open_apitest.cc

Issue 13139004: Deprecate Browser::TYPE_PANEL (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/window_open_apitest.cc
diff --git a/chrome/browser/extensions/window_open_apitest.cc b/chrome/browser/extensions/window_open_apitest.cc
index ab823620585d9b0a1cc668b88eedbe07b24ed05a..a2ab6b2e57a639fd449f1b9ddd3e5a92dd74f457 100644
--- a/chrome/browser/extensions/window_open_apitest.cc
+++ b/chrome/browser/extensions/window_open_apitest.cc
@@ -92,13 +92,7 @@ bool WaitForTabsAndPopups(Browser* browser,
if (*iter == browser)
continue;
- // Check for TYPE_POPUP.
-#if defined(USE_ASH_PANELS)
- // On Ash, panel windows may open as popup windows.
- EXPECT_TRUE((*iter)->is_type_popup() || (*iter)->is_type_panel());
-#else
EXPECT_TRUE((*iter)->is_type_popup());
-#endif
++num_popups_seen;
}
EXPECT_EQ(num_popups, num_popups_seen);

Powered by Google App Engine
This is Rietveld 408576698