chrome/browser/extensions/browser_extension_window_controller.cc - Issue 13139004: Deprecate Browser::TYPE_PANEL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/browser_extension_window_controller.cc

Issue 13139004: Deprecate Browser::TYPE_PANEL (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/browser_extension_window_controller.cc

diff --git a/chrome/browser/extensions/browser_extension_window_controller.cc b/chrome/browser/extensions/browser_extension_window_controller.cc

index be8c349f891a2d44bb3a7d6bd490cff0983573ee..93e99476d932bfd53a8f33c1e3ed407e910a4d40 100644

--- a/chrome/browser/extensions/browser_extension_window_controller.cc

+++ b/chrome/browser/extensions/browser_extension_window_controller.cc

@@ -34,8 +34,6 @@ namespace keys = extensions::tabs_constants;

std::string BrowserExtensionWindowController::GetWindowTypeText() const {

if (browser_->is_type_popup())

return keys::kWindowTypeValuePopup;

- if (browser_->is_type_panel())

- return keys::kWindowTypeValuePanel;

if (browser_->is_app())

return keys::kWindowTypeValueApp;

return keys::kWindowTypeValueNormal;