Deprecate Browser::TYPE_PANEL

chrome/browser/ui/uma_browsing_activity_observer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/uma_browsing_activity_observer.h"
 
 #include "base/metrics/histogram.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/browser_iterator.h"
@@ skipping 53 matching lines @@
           content::RenderProcessHost::AllHostsIterator());
         !i.IsAtEnd(); i.Advance())
     ++hosts_count;
   UMA_HISTOGRAM_CUSTOM_COUNTS("MPArch.RPHCountPerLoad", hosts_count,
                               1, 50, 50);
 }
 
 void UMABrowsingActivityObserver::LogBrowserTabCount() const {
   int tab_count = 0;
   int app_window_count = 0;
   int panel_window_count = 0;

[Dmitry Titov, 2013/04/02 21:21:50]

Should the panel counter be removed from here?

[stevenjb, 2013/04/02 21:38:43]

Yep. And UMA counts below. And the histogram entry (in a separate CL). Done.

   int popup_window_count = 0;
   int tabbed_window_count = 0;
   for (chrome::BrowserIterator it; !it.done(); it.Next()) {
     // Record how many tabs each window has open.
     Browser* browser = *it;
     UMA_HISTOGRAM_CUSTOM_COUNTS("Tabs.TabCountPerWindow",
                                 browser->tab_strip_model()->count(),
                                 1, 200, 50);
     tab_count += browser->tab_strip_model()->count();
 
     if (browser->window()->IsActive()) {
       // Record how many tabs the active window has open.
       UMA_HISTOGRAM_CUSTOM_COUNTS("Tabs.TabCountActiveWindow",
                                   browser->tab_strip_model()->count(),
                                   1, 200, 50);
     }
 
     if (browser->is_app())
       app_window_count++;
-    else if (browser->is_type_panel())
-      panel_window_count++;
     else if (browser->is_type_popup())
       popup_window_count++;
     else if (browser->is_type_tabbed())
       tabbed_window_count++;
   }
   // Record how many tabs total are open (across all windows).
   UMA_HISTOGRAM_CUSTOM_COUNTS("Tabs.TabCountPerLoad", tab_count, 1, 200, 50);
 
   // Record how many windows are open, by type.
   UMA_HISTOGRAM_COUNTS_100("WindowManager.AppWindowCountPerLoad",
                            app_window_count);
   UMA_HISTOGRAM_COUNTS_100("WindowManager.PanelWindowCountPerLoad",
                            panel_window_count);
   UMA_HISTOGRAM_COUNTS_100("WindowManager.PopUpWindowCountPerLoad",
                            popup_window_count);
   UMA_HISTOGRAM_COUNTS_100("WindowManager.TabbedWindowCountPerLoad",
                            tabbed_window_count);
 }
 
 }  // namespace chrome