Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13136002: AwContentClient no longer extends ContentViewClient (Closed)

Created:
7 years, 9 months ago by joth
Modified:
7 years, 7 months ago
Reviewers:
mkosiba (inactive)
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

AwContentClient no longer extends ContentViewClient This keeps the layers better isolated, and avoids the aw embedder having to use content layer classes directly. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197181

Patch Set 1 #

Patch Set 2 : ready #

Patch Set 3 : fix tests #

Total comments: 4

Patch Set 4 : mksoiba comment. AwContentsClientShouldIgnoreNavigationTest.java -> AwContentsClientShouldOverrideU… #

Patch Set 5 : rebase #

Patch Set 6 : Add missing onScaleChanged call #

Messages

Total messages: 10 (0 generated)
joth
as we discussed in https://codereview.chromium.org/12567020/diff/1/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java#newcode38
7 years, 9 months ago (2013-03-28 02:44:47 UTC) #1
mkosiba (inactive)
Cool! LGTM https://codereview.chromium.org/13136002/diff/6001/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldIgnoreNavigationTest.java File android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldIgnoreNavigationTest.java (right): https://codereview.chromium.org/13136002/diff/6001/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldIgnoreNavigationTest.java#newcode35 android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldIgnoreNavigationTest.java:35: * implementt the feature). nit: implement https://codereview.chromium.org/13136002/diff/6001/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldIgnoreNavigationTest.java#newcode37 ...
7 years, 9 months ago (2013-03-28 09:59:14 UTC) #2
joth
thanks! https://codereview.chromium.org/13136002/diff/6001/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldIgnoreNavigationTest.java File android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldIgnoreNavigationTest.java (right): https://codereview.chromium.org/13136002/diff/6001/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldIgnoreNavigationTest.java#newcode35 android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldIgnoreNavigationTest.java:35: * implementt the feature). On 2013/03/28 09:59:14, Martin ...
7 years, 9 months ago (2013-03-29 00:40:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joth@chromium.org/13136002/11001
7 years, 9 months ago (2013-03-29 00:41:19 UTC) #4
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
7 years, 8 months ago (2013-03-29 06:05:57 UTC) #5
mkosiba (inactive)
yo! did this ever go in?
7 years, 7 months ago (2013-04-29 10:33:49 UTC) #6
joth
On 2013/04/29 10:33:49, mkosiba wrote: > yo! did this ever go in? No! Bah. I'll ...
7 years, 7 months ago (2013-04-29 16:12:37 UTC) #7
joth
Carrying over lgtm from before. (Only substantive change is onScaleChanged added to the inner ContentViewClient ...
7 years, 7 months ago (2013-04-29 20:57:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joth@chromium.org/13136002/48003
7 years, 7 months ago (2013-04-29 20:57:21 UTC) #9
commit-bot: I haz the power
7 years, 7 months ago (2013-04-29 23:13:43 UTC) #10
Message was sent while issue was closed. 
Change committed as 197181

Powered by Google App Engine
This is Rietveld 408576698