Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 13124003: Fix v2 app launch vector stats (Closed)

Created:
7 years, 9 months ago by calamity
Modified:
7 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix v2 app launch vector stats APP_LAUNCH_BOOKMARK_BAR incorrectly always being logged as v2 app on windows. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191291

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
calamity
7 years, 9 months ago (2013-03-28 00:19:46 UTC) #1
calamity
+sky for OWNERS
7 years, 9 months ago (2013-03-28 00:25:30 UTC) #2
sky
LGTM
7 years, 9 months ago (2013-03-28 16:22:41 UTC) #3
benwells
On 2013/03/28 16:22:41, sky wrote: > LGTM checking box for calamity...
7 years, 9 months ago (2013-03-28 19:46:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/13124003/1
7 years, 9 months ago (2013-03-28 19:48:28 UTC) #5
commit-bot: I haz the power
7 years, 9 months ago (2013-03-29 04:11:29 UTC) #6
Message was sent while issue was closed.
Change committed as 191291

Powered by Google App Engine
This is Rietveld 408576698