Issue 13119014: Telemetry: Don't silently compare histograms from different processes.

Issue 13119014: Telemetry: Don't silently compare histograms from different processes. (Closed)

Created:
7 years, 9 months ago by marja

Modified:
7 years, 8 months ago

Reviewers:
dtu, Ilya Sherman

CC:
chromium-reviews, chrome-speed-team+watch_google.com, MAD, erikwright+watch_chromium.org, Ilya Sherman, jar (doing other things)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Telemetry: Don't silently compare histograms from different processes. We used to do so, and the resulting data doesn't make sense. BUG=224262 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192526 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192533

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	base/metrics/histogram_base.cc	View	1 2 3	2 chunks	+2 lines, -0 lines	0 comments	Download
	M	tools/perf/perf_tools/histogram.py	View	1 2	1 chunk	+7 lines, -1 line	0 comments	Download

Total messages: 8 (0 generated)

marja

Could you review: isherman: base/metrics/histogram_base.cc dtu: tools/perf/perf_tools/histogram.py tonyg@: I don't think I can land this ...

7 years, 9 months ago (2013-03-27 16:26:43 UTC) #1

tonyg

On 2013/03/27 22:11:43, Dave Tu wrote: > lgtm Yeah, please don't land without a fix ...

7 years, 9 months ago (2013-03-27 22:22:57 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/13119014/8001

7 years, 8 months ago (2013-04-05 07:38:40 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/13119014/14003

7 years, 8 months ago (2013-04-05 09:19:50 UTC) #7

Message was sent while issue was closed.

Change committed as 192533