[Android] Allow Java libraries to access resources from dependencies.

[Android] Allow Java libraries to access resources from dependencies.

Libraries could previously access dependencies' resources in Java code
but not in XML layout files. This enables accessing these resources in
layout files as well, with the compromise that resources can now be
accessed using the wrong package name in Java code. Since resource
names are global anyway (an APK can't contain two resources with the
same name), this is deemed OK.

BUG=176069
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190896

[newt (away), 2013-03-27 00:33:32]

PTAL

[cjhopman, 2013-03-27 00:37:50]

https://codereview.chromium.org/13107002/diff/1/build/java.gypi
File build/java.gypi (right):

https://codereview.chromium.org/13107002/diff/1/build/java.gypi#newcode141
build/java.gypi:141: # https://code.google.com/p/gyp/issues/detail?id=328 is
fixed.
Could this bug be due to the fact that all_res_dirs is early expanded below?

[newt (away), 2013-03-27 00:48:59]

yup. better now.

[cjhopman, 2013-03-27 00:54:04]

https://codereview.chromium.org/13107002/diff/4001/build/java.gypi
File build/java.gypi (right):

https://codereview.chromium.org/13107002/diff/4001/build/java.gypi#newcode137
build/java.gypi:137: # Include the depedencies' res dirs so that references to
nit: s/depedencies/dependencies

https://codereview.chromium.org/13107002/diff/4001/build/java.gypi#newcode144
build/java.gypi:144: '>@(resource_input_paths)',
Does anything need to be added to the inputs to ensure this is rebuilt when a
dependencies resources change?

[newt (away), 2013-03-27 01:20:13]

https://codereview.chromium.org/13107002/diff/4001/build/java.gypi
File build/java.gypi (right):

https://codereview.chromium.org/13107002/diff/4001/build/java.gypi#newcode137
build/java.gypi:137: # Include the depedencies' res dirs so that references to
On 2013/03/27 00:54:04, cjhopman wrote:
> nit: s/depedencies/dependencies

Done.

https://codereview.chromium.org/13107002/diff/4001/build/java.gypi#newcode144
build/java.gypi:144: '>@(resource_input_paths)',
On 2013/03/27 00:54:04, cjhopman wrote:
> Does anything need to be added to the inputs to ensure this is rebuilt when a
> dependencies resources change?

Done.

[cjhopman, 2013-03-27 01:24:32]

lgtm

[commit-bot: I haz the power, 2013-03-27 01:30:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/newt@chromium.org/13107002/11001

[commit-bot: I haz the power, 2013-03-27 09:48:04]

Change committed as 190896