chrome/browser/banners/app_banner_debug_log.h - Issue 1310223002: webapps: initial addition of splash screen icon downloading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/banners/app_banner_debug_log.h

Issue 1310223002: webapps: initial addition of splash screen icon downloading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webapps-database-exp

Patch Set: Fix review comments and update code as discussed Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/banners/app_banner_data_fetcher.h ('K') | « chrome/browser/banners/app_banner_data_fetcher.h ('k') | chrome/browser/banners/app_banner_debug_log.cc » ('j') | chrome/browser/banners/app_banner_debug_log.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/banners/app_banner_debug_log.h

diff --git a/chrome/browser/banners/app_banner_debug_log.h b/chrome/browser/banners/app_banner_debug_log.h

index dfcc1473f45152cc30a8b7aa045b556880fd6f05..0fa8f0d007b43fbd7049120bd77bfcd6a9d2a4e9 100644

--- a/chrome/browser/banners/app_banner_debug_log.h

+++ b/chrome/browser/banners/app_banner_debug_log.h

@@ -17,8 +17,10 @@ namespace banners {

extern const char kRendererRequestCancel[];

extern const char kManifestEmpty[];

extern const char kCannotDetermineBestIcon[];

+extern const char kCannotDetermineBestSplashIcon[];

extern const char kNoMatchingServiceWorker[];

extern const char kNoIconAvailable[];

+extern const char kNoSplashIconAvailable[];

extern const char kBannerAlreadyAdded[];

extern const char kUserNavigatedBeforeBannerShown[];

extern const char kStartURLNotValid[];