Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: chrome/browser/android/banners/app_banner_data_fetcher_android.h

Issue 1310223002: webapps: initial addition of splash screen icon downloading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webapps-database-exp
Patch Set: Fix review comments and update code as discussed Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/banners/app_banner_data_fetcher_android.h
diff --git a/chrome/browser/android/banners/app_banner_data_fetcher_android.h b/chrome/browser/android/banners/app_banner_data_fetcher_android.h
index 4858085f4c6fb92ce18011ed2e333c36ffaf4063..d45f8d0b3a3f0e53220c2e75ca28fe77152f433c 100644
--- a/chrome/browser/android/banners/app_banner_data_fetcher_android.h
+++ b/chrome/browser/android/banners/app_banner_data_fetcher_android.h
@@ -17,6 +17,7 @@ class AppBannerDataFetcherAndroid : public AppBannerDataFetcher {
AppBannerDataFetcherAndroid(
content::WebContents* web_contents,
base::WeakPtr<Delegate> weak_delegate,
+ int ideal_splash_icon_size,
int ideal_icon_size);
// Saves information about the Android app being promoted by the current page,
@@ -26,6 +27,9 @@ class AppBannerDataFetcherAndroid : public AppBannerDataFetcher {
base::android::ScopedJavaLocalRef<jobject> app_data,
const GURL& image_url);
+ // Fetches the splashscreen icon and stores it in the webapp's data storage.
gone 2015/08/26 02:01:19 nit: use WebappDataStorage to be explicit.
Lalit Maganti 2015/08/26 13:11:56 Done.
+ void FetchWebappSplashscreenIcon(const std::string& webapp_id);
+
protected:
~AppBannerDataFetcherAndroid() override;
@@ -40,6 +44,8 @@ class AppBannerDataFetcherAndroid : public AppBannerDataFetcher {
base::android::ScopedJavaGlobalRef<jobject> native_app_data_;
std::string native_app_package_;
+ int ideal_splash_icon_size_;
Lalit Maganti 2015/08/26 13:11:56 Changed to image and added dp qualifier.
+
DISALLOW_COPY_AND_ASSIGN(AppBannerDataFetcherAndroid);
};

Powered by Google App Engine
This is Rietveld 408576698