Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java

Issue 1310223002: webapps: initial addition of splash screen icon downloading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webapps-database-exp
Patch Set: Fix small issues Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java
index d31737a9f659a011af5a91725ffcb438d7294f87..8199d665721e35b38367e40974c03650026111d4 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java
@@ -46,7 +46,10 @@ public class AddToHomescreenDialogHelper {
*/
public void initialize(Observer observer) {
mObserver = observer;
- mNativeAddToHomescreenDialogHelper = nativeInitialize(mTab.getWebContents());
+ mNativeAddToHomescreenDialogHelper = nativeInitialize(
+ mTab.getWebContents(),
gone 2015/08/26 21:39:25 Indentation continues to be wrong. This is java c
Lalit Maganti 2015/08/26 22:55:00 :/ Another thing I need to look at before sending
+ ShortcutHelper.getIdealSplashImageSizeInDp(mAppContext.getResources()),
+ ShortcutHelper.getIdealIconSizeInDp(mAppContext.getResources()));
}
/**
@@ -97,7 +100,8 @@ public class AddToHomescreenDialogHelper {
ApplicationStatus.getApplicationContext(), icon, url, red, green, blue);
}
- private native long nativeInitialize(WebContents webContents);
+ private native long nativeInitialize(WebContents webContents,
+ int idealSplashImageSizeInDp, int idealIconSizeInDp);
private native void nativeAddShortcut(long nativeAddToHomescreenDialogHelper,
String userRequestedTitle);
private native void nativeDestroy(long nativeAddToHomescreenDialogHelper);

Powered by Google App Engine
This is Rietveld 408576698