ppapi/PRESUBMIT.py - Issue 13093006: Update PRESUBMIT scripts to use PresubmitPromptOrNotify helper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/PRESUBMIT.py

Issue 13093006: Update PRESUBMIT scripts to use PresubmitPromptOrNotify helper. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/PRESUBMIT.py

diff --git a/ppapi/PRESUBMIT.py b/ppapi/PRESUBMIT.py

index 9b6f716f050cbb4de11a681a91b2c43a53d4df68..1a950034e4cfb17b031ce8b7c091b1928e8b3926 100644

--- a/ppapi/PRESUBMIT.py

+++ b/ppapi/PRESUBMIT.py

@@ -175,7 +175,7 @@ def CheckChange(input_api, output_api):

for line in lines:

if line[2].split()[:2] == ['#define', 'PPAPI_RELEASE']:

results.append(

- output_api.PresubmitNotifyResult(

+ output_api.PresubmitPromptOrNotify(

'PPAPI_RELEASE has changed', long_text=line[2]))

releaseChanged = True

break

« no previous file with comments | « PRESUBMIT_test.py ('k') | no next file » | no next file with comments »