Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 13093006: Update PRESUBMIT scripts to use PresubmitPromptOrNotify helper. (Closed)

Created:
7 years, 9 months ago by Wez
Modified:
7 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Update PRESUBMIT scripts to use PresubmitPromptOrNotify helper. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191863

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -39 lines) Patch
M PRESUBMIT.py View 1 4 chunks +4 lines, -25 lines 0 comments Download
M PRESUBMIT_test.py View 1 2 chunks +6 lines, -13 lines 0 comments Download
M ppapi/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Wez
PTAL (FYI I got an error about missing base files _after_ the base files had ...
7 years, 9 months ago (2013-03-26 18:02:45 UTC) #1
M-A Ruel
https://chromiumcodereview.appspot.com/13093006/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://chromiumcodereview.appspot.com/13093006/diff/1/PRESUBMIT.py#newcode226 PRESUBMIT.py:226: # We don't warn on commit, to avoid stopping ...
7 years, 9 months ago (2013-03-26 18:05:00 UTC) #2
Wez
https://chromiumcodereview.appspot.com/13093006/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://chromiumcodereview.appspot.com/13093006/diff/1/PRESUBMIT.py#newcode226 PRESUBMIT.py:226: # We don't warn on commit, to avoid stopping ...
7 years, 9 months ago (2013-03-26 20:08:02 UTC) #3
Wez
Le ping.
7 years, 8 months ago (2013-04-01 20:34:12 UTC) #4
M-A Ruel
lgtm
7 years, 8 months ago (2013-04-02 15:58:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/13093006/5001
7 years, 8 months ago (2013-04-02 15:58:52 UTC) #6
commit-bot: I haz the power
Presubmit check for 13093006-5001 failed and returned exit status 1. INFO:root:Found 3 file(s). testBadOrigFile (__main__.BadExtensionsTest) ...
7 years, 8 months ago (2013-04-02 15:58:58 UTC) #7
Wez
dmichael: PTAL ppapi/PRESUBMIT.py
7 years, 8 months ago (2013-04-02 18:26:13 UTC) #8
dmichael (off chromium)
ppapi/* lgtm
7 years, 8 months ago (2013-04-02 18:27:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/13093006/5001
7 years, 8 months ago (2013-04-02 18:29:34 UTC) #10
commit-bot: I haz the power
7 years, 8 months ago (2013-04-02 18:31:44 UTC) #11
Message was sent while issue was closed.
Change committed as 191863

Powered by Google App Engine
This is Rietveld 408576698